From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 545E2C05027 for ; Mon, 30 Jan 2023 00:55:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 85CEC85367; Mon, 30 Jan 2023 01:55:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id ADE1C85602; Mon, 30 Jan 2023 01:55:50 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4CF2885348 for ; Mon, 30 Jan 2023 01:55:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id 6DF843C0114; Mon, 30 Jan 2023 08:55:29 +0800 (CST) Message-ID: <56319ff0-54fa-1304-44d4-bcbe4bb6e8a8@rock-chips.com> Date: Mon, 30 Jan 2023 08:55:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support Content-Language: en-US To: Jonas Karlman , Jagan Teki , Simon Glass , Philipp Tomsich , fatorangecat@189.cn Cc: u-boot@lists.denx.de References: <20230125222741.303259-1-jagan@edgeble.ai> <2efd56b6-4dc9-cd77-3792-e60142faa6ae@kwiboo.se> <18e1e8b9-4f66-5bf0-b0a7-fb9075bb9fc5@rock-chips.com> From: Kever Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJSktLSjdXWS1ZQUlXWQ8JGhUIEh9ZQVkZGUIfVhhJHx1JSxlLTEkZQlUTARMWGhIXJB QOD1lXWRgSC1lBWU5DVUlJVUxVSkpPWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVSktLVUtZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Nxg6Thw6OD0NSTkQETMwNxlD Di1PCR5VSlVKTUxOS09LSkhLS0pCVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFPQ0JNNwY+ X-HM-Tid: 0a86002c023b2eb0kusn6df843c0114 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Jonas, On 2023/1/29 17:58, Jonas Karlman wrote: > Hi Kever, > On 2023-01-29 10:47, Kever Yang wrote: >> Hi Jonas, Jagan, >> >> On 2023/1/26 06:47, Jonas Karlman wrote: >>> Hi Jagan, >>> >>> On 2023-01-25 23:27, Jagan Teki wrote: >>>> This series support Rockchip RK3588. All the device tree files are >>>> synced from linux-next with the proper SHA1 mentioned in the commit >>>> messages. >>>> >>>> Unfortunately, the BL31 from rkbin is not compatible with U-Boot so >>>> it is failing to load ATF entry from SPL and hang. >>>> >>>> Verified below BL31 versions, >>>> bl31-v1.15 >>>> bl31-v1.21 >>>> bl31-v1.22 >>>> bl31-v1.23 >>>> bl31-v1.24 >>>> bl31-v1.25 >>>> bl31-v1.26 >>>> >>>> Rever-engineered with respect to rockchip u-boot by using the same >>>> FIT_GENERATOR being used in Mainline, rockchip u-boot is booting but >>>> mainline showing the same issue. >>>> >>>> Log: >>>> >>>> LPDDR4X, 2112MHz01-00642-g6bdfd31756-dirty (Jan 26 2023 ���3:44:34 +0530) >>>> channel[0] BW=16 Col=10 Bk=8 CS0 Row=17 CS1 Row=17 CS=2 Die BW=8 Size=4096MB >>>> channel[1] BW=16 Col=10 Bk=8 CS0 Row=17 CS1 Row=17 CS=2 Die BW=8 Size=4096MB >>>> channel[2] BW=16 Col=10 Bk=8 CS0 Row=17 CS1 Row=17 CS=2 Die BW=8 Size=4096MB >>>> channel[3] BW=16 Col=10 Bk=8 CS0 Row=17 CS1 Row=17 CS=2 Die BW=8 Size=4096MB >>>> change to F1: 528MHz >>>> change to F2: 1068MHz >>>> change to F3: 1560MHz >>>> change to F0: 2112MHz >>>> out >>>> >>>> U-Boot SPL 2023.01-00642-g6bdfd31756-dirty (Jan 26 2023 - 03:44:34 +0530) >>>> Trying to boot from MMC1 >>>> bl31_entry: atf_entry start >>>> << hang >> >>>> >>>> Any information on BL31 for RK3588 please share. >>> I had a similar strange booing issue with RK3568 and mainline U-Boot, >>> turned out to be related to all parts of ATF not being properly loaded >>> into PMU SRAM. >> For this issue, could you try to add below property for mmc dts node? >> >> "u-boot,spl-fifo-mode" >> >> The emmc/sdmmc controller do not have a direct path to the SRAM, so we >> can't use >> >> its internal DMA to do the data transfer.  The "fifo-mode" will use CPU >> to do the data >> >> copy instead of the internal DMA. > For sdmmc this worked, but for emmc it did not, trying to use the emmc without > SDMA seemed to cause issues reading data in general, did not fully investigate why. The sdmmc is using driver rockchip_dw_mmc.c while the emmc is using the driver rockchip_sdhci.c, I think this is the root cause for the "spl-fifo-mode" only only works on sdmmc. Thanks, - Kever > I am thinking we could use some sort of mechanism to signal mkimage that we want to > keep the parts that should be loaded into SRAM as embedded data instead of external data. > That way the FIT can be loaded using DMA into DRAM, and the embedded data will then > be memcpy into SRAM using CPU. > > I quickly tested [0] and this seem to work and we do not need to use the fifo-mode > to work around this DMA to SRAM issue. Will work on a proper RFC for such solution. > > [0] https://github.com/Kwiboo/u-boot-rockchip/commit/551b02a5cd7d28244f44b2e7d7a29196305c26f6 > > Regards, > Jonas > >> >> Thanks, >> >> - Kever >>