From: Ralph Boehme <slow@samba.org>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs@vger.kernel.org,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Steve French <smfrench@gmail.com>
Subject: Re: [PATCH] ksmbd: remove follow symlinks support
Date: Mon, 20 Sep 2021 18:28:29 +0200 [thread overview]
Message-ID: <5633aaea-84f3-ce70-ff14-aa2dc80a93b8@samba.org> (raw)
In-Reply-To: <CAKYAXd9Re_iHpwKq4t4GUibKo8g_D3QB1rzBOYiTvv5dLhdvsw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 523 bytes --]
Am 20.09.21 um 17:57 schrieb Namjae Jeon:
> ksmbd_vfs_kern_path() doesn't return -ELOOP if last component is a
> symlink. So need to check it using d_is_symlink().
Really? I missed that. Is that a behaviour of kern_path() when passing
LOOKUP_NO_SYMLINKS? I don't see the behaviour expressed inside
ksmbd_vfs_kern_path(), but maybe I'm looking at the wrong branch+patchset?
-slow
--
Ralph Boehme, Samba Team https://samba.org/
SerNet Samba Team Lead https://sernet.de/en/team-samba
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-09-20 16:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 6:56 [PATCH] ksmbd: remove follow symlinks support Namjae Jeon
2021-09-20 13:57 ` Ralph Boehme
2021-09-20 15:57 ` Namjae Jeon
2021-09-20 16:28 ` Ralph Boehme [this message]
2021-09-20 16:37 ` Namjae Jeon
2021-09-21 7:44 ` Ralph Boehme
2021-09-20 14:44 ` Ralph Boehme
2021-09-20 15:19 ` Steve French
2021-09-20 15:55 ` Ralph Boehme
2021-09-20 16:03 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5633aaea-84f3-ce70-ff14-aa2dc80a93b8@samba.org \
--to=slow@samba.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.