From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH 2/3] vhost: Add callback and private data for vhost PMD Date: Mon, 2 Nov 2015 12:15:03 +0900 Message-ID: <5636D537.9020609@igel.co.jp> References: <1445507150-1481-2-git-send-email-mukawa@igel.co.jp> <1445926375-18986-1-git-send-email-mukawa@igel.co.jp> <1445926375-18986-3-git-send-email-mukawa@igel.co.jp> <74F120C019F4A64C9B78E802F6AD4CC24F7B3695@IRSMSX106.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "ann.zhuangyanying@huawei.com" To: "Loftus, Ciara" , "dev@dpdk.org" Return-path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id E7EFB8DA1 for ; Mon, 2 Nov 2015 04:15:06 +0100 (CET) Received: by padec8 with SMTP id ec8so24315162pad.1 for ; Sun, 01 Nov 2015 19:15:06 -0800 (PST) In-Reply-To: <74F120C019F4A64C9B78E802F6AD4CC24F7B3695@IRSMSX106.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2015/10/31 2:49, Loftus, Ciara wrote: >> These variables are needed to be able to manage one of virtio devices >> using both vhost library APIs and vhost PMD. >> For example, if vhost PMD uses current callback handler and private data >> provided by vhost library, A DPDK application that links vhost library >> cannot use some of vhost library APIs. To avoid it, callback and private >> data for vhost PMD are needed. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_vhost/rte_vhost_version.map | 6 +++ >> lib/librte_vhost/rte_virtio_net.h | 3 ++ >> lib/librte_vhost/vhost_user/virtio-net-user.c | 13 +++---- >> lib/librte_vhost/virtio-net.c | 56 +++++++++++++++++++++++++-- >> lib/librte_vhost/virtio-net.h | 4 +- >> 5 files changed, 70 insertions(+), 12 deletions(-) >> > Hi Tetsuya, > > Thanks for implementing this. I haven't had a chance to actually test it, but if these changes allow users of the PMD to implement their own new_ and destroy_ device functions etc, that's good news. > > Thanks, > Ciara Hi Ciara, Yes, the patch works like you said. Thanks, Tetsuya