All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <nks@flawful.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Guenter Roeck" <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] serial: etraxfs-uart: Fix crash
Date: Mon, 2 Nov 2015 22:13:25 +0100	[thread overview]
Message-ID: <5637D1F5.2090608@flawful.org> (raw)
In-Reply-To: <20151102073755.GN4931@pengutronix.de>



On 11/02/2015 08:37 AM, Uwe Kleine-König wrote:
>> The function call in the etraxfs-uart driver was not renamed,
>> possibly due to interference with commit 7b9c5162c182 ("serial:
>> etraxfs-uart: use mctrl_gpio helpers for handling modem signals").
> Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handling
> is missing.

The only drivers including serial_mctrl_gpio.h is atmel_serial.c,
clps711x.c, mxs-auart.c and etraxfs-uart.c

etraxfs commit
7b9c5162c182 ("serial: etraxfs-uart: use mctrl_gpio helpers for handling modem signals")
is heavily influenced by
62b0a1b3e759 ("serial: clps711x: Use mctrl_gpio helpers for handling modem signals")

a driver which also appears to lack mctrl irq setup/handling.


Uwe, are you going to convert all serial drivers that includes serial_mctrl_gpio.h to
use the new mctrl_gpio_init? (which also sets up irqs)

Since mctrl gpios are optional in the device tree, I guess mctrl_gpio_init handles if
they are missing. So even if etraxfs-uart.c currently lacks mctrl irq setup/handling,
if we migrate it to use the new mctrl_gpio_init, we will get this automatically?

  parent reply	other threads:[~2015-11-02 21:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02  2:32 [PATCH -next] serial: etraxfs-uart: Fix crash Guenter Roeck
2015-11-02  7:37 ` Uwe Kleine-König
2015-11-02 14:29   ` Guenter Roeck
2015-11-02 15:39     ` Uwe Kleine-König
2015-11-02 21:13   ` Niklas Cassel [this message]
2015-11-02 21:29     ` Uwe Kleine-König
2015-11-15 23:54       ` Niklas Cassel
2015-11-16  0:42         ` Guenter Roeck
2015-11-02 16:24 ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5637D1F5.2090608@flawful.org \
    --to=nks@flawful.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.