From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Chou <thomas@wytron.com.tw>
Date: Tue, 3 Nov 2015 08:23:18 +0800
Subject: [U-Boot] [PATCH v3 2/3] cfi_flash: convert to driver model
In-Reply-To: <56371CE1.9000203@denx.de>
References: <1444289667-23775-1-git-send-email-thomas@wytron.com.tw>
 <1446212027-20630-1-git-send-email-thomas@wytron.com.tw>
 <1446212027-20630-2-git-send-email-thomas@wytron.com.tw>
 <56371CE1.9000203@denx.de>
Message-ID: <5637FE76.3050208@wytron.com.tw>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefan,

On 2015?11?02? 16:20, Stefan Roese wrote:
>> @@ -2315,6 +2329,7 @@ unsigned long flash_init (void)
>>    {
>>    	unsigned long size = 0;
>>    	int i;
>> +	struct udevice *dev;
>
> I'm seeing this warning while compiling for some powerpc boards
> (e.g. canyonlands):
>
> drivers/mtd/cfi_flash.c: In function 'flash_init':
> drivers/mtd/cfi_flash.c:2332:18: warning: unused variable 'dev' [-Wunused-variable]
>
> Perhaps an "__maybe_unused" needed here.

>
>>
>>    #ifdef CONFIG_SYS_FLASH_PROTECTION
>>    	/* read environment from EEPROM */
>> @@ -2322,6 +2337,14 @@ unsigned long flash_init (void)
>>    	getenv_f("unlock", s, sizeof(s));
>>    #endif
>>
>> +#ifdef CONFIG_CFI_FLASH /* for driver model */
>> +	cfi_flash_num_flash_banks = 0;
>> +	/* probe every MTD device */
>> +	for (uclass_first_device(UCLASS_MTD, &dev);
>> +	     dev;
>> +	     uclass_next_device(&dev)) {
>> +	}
>> +#endif
>
> What is this loop above exactly doing?

I want to get the cfi-flash device probed and flash_info[] got 
initialized. So I look in every mtd uclass device.

I will use CONFIG_IS_ENABLED to remove the warning above.

if (CONFIG_IS_ENABLED(CFI_FLASH)) {
	struct udevice *dev;
	cfi_flash_num_flash_banks = 0;
	/* probe every MTD device to find cfi-flash device */
	for (uclass_first_device(UCLASS_MTD, &dev);
	     dev;
	     uclass_next_device(&dev)) {
	}
}

Thanks a lot.

Best regards,
Thomas