From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztfvt-0004gD-NN for qemu-devel@nongnu.org; Tue, 03 Nov 2015 13:03:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ztfvq-00074V-A1 for qemu-devel@nongnu.org; Tue, 03 Nov 2015 13:03:45 -0500 Received: from relay.parallels.com ([195.214.232.42]:34573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztfvq-00073d-1p for qemu-devel@nongnu.org; Tue, 03 Nov 2015 13:03:42 -0500 References: <1446151457-21157-1-git-send-email-den@openvz.org> <20151103171042.GI15414@stefanha-x1.localdomain> <5638EFDA.10107@redhat.com> <5638F216.3080207@openvz.org> <5638F3FC.8020902@redhat.com> From: "Denis V. Lunev" Message-ID: <5638F6F0.9080207@openvz.org> Date: Tue, 3 Nov 2015 21:03:28 +0300 MIME-Version: 1.0 In-Reply-To: <5638F3FC.8020902@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints, and connect them to logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Stefan Hajnoczi Cc: qemu-devel@nongnu.org On 11/03/2015 08:50 PM, Paolo Bonzini wrote: > > On 03/11/2015 18:42, Denis V. Lunev wrote: >> There 2 small notes here: >> - there is small patch with 'all' alias for all tracepoints which >> could also be useful in the scope of this work: >> [PATCH v2 1/1] allow to enable all tracepoints via alias all >> >> - it would be great if patches from my log patchset will be merged. >> I'll port them tomorrow on top of this set (if will not work on >> findings in locking patchset) >> Switch from inline call to #define and QMP/QAPI logging seems >> really necessary. timestamp could be enabled or not but it is >> better to use unified approach for logging timestamps and >> tracing timestamps. > I think the "right" way would be to add tracepoints to the qmp_* > functions, or to make your logging a tracepoint. BTW, why are you not > logging QMP commands from the Virtuozzo management tool? That's what > libvirt is doing, you can find the JSON in qemu.log IIRC. > > Paolo because libvirt is maintained by the different team and I have to find a way to prove the side of the problem ;) OK. using tracepoint for this (after this patchset) could be fine. Thank you for an idea, I'll elaborate this tomorrow. Den