From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtoBa-0006Xi-Gq for qemu-devel@nongnu.org; Tue, 03 Nov 2015 21:52:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtoBX-0007E4-Af for qemu-devel@nongnu.org; Tue, 03 Nov 2015 21:52:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtoBX-0007Dm-4u for qemu-devel@nongnu.org; Tue, 03 Nov 2015 21:52:27 -0500 References: <1446551816-15768-1-git-send-email-zhang.zhanghailiang@huawei.com> <1446551816-15768-35-git-send-email-zhang.zhanghailiang@huawei.com> <5638AC0F.1090500@easystack.cn> From: Jason Wang Message-ID: <563972E4.3090109@redhat.com> Date: Wed, 4 Nov 2015 10:52:20 +0800 MIME-Version: 1.0 In-Reply-To: <5638AC0F.1090500@easystack.cn> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH COLO-Frame v10 34/38] filter-buffer: Accept zero interval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , zhanghailiang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, dgilbert@redhat.com, peter.huangpeng@huawei.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com On 11/03/2015 08:43 PM, Yang Hongyang wrote: > Some commit message would be better. +1 > > On 2015=E5=B9=B411=E6=9C=8803=E6=97=A5 19:56, zhanghailiang wrote: >> Signed-off-by: zhanghailiang >> Cc: Jason Wang > > Reviewed-by: Yang Hongyang > >> --- >> v10: new patch >> --- >> net/filter-buffer.c | 10 ---------- >> 1 file changed, 10 deletions(-) >> >> diff --git a/net/filter-buffer.c b/net/filter-buffer.c >> index 5f0ea70..05313de 100644 >> --- a/net/filter-buffer.c >> +++ b/net/filter-buffer.c >> @@ -104,16 +104,6 @@ static void filter_buffer_setup(NetFilterState >> *nf, Error **errp) >> { >> FilterBufferState *s =3D FILTER_BUFFER(nf); >> >> - /* >> - * We may want to accept zero interval when VM FT solutions like = MC >> - * or COLO use this filter to release packets on demand. >> - */ >> - if (!s->interval) { >> - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval", >> - "a non-zero interval"); >> - return; >> - } >> - >> s->incoming_queue =3D >> qemu_new_net_queue(qemu_netfilter_pass_to_next, nf); >> if (s->interval) { >> timer_init_us(&s->release_timer, QEMU_CLOCK_VIRTUAL, >> >