All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name
Date: Thu, 5 Nov 2015 11:02:21 +0300	[thread overview]
Message-ID: <563B0D0D.5070806@openvz.org> (raw)
In-Reply-To: <20151105085558.31d3a8f3@bahia.local>

On 11/05/2015 10:55 AM, Greg Kurz wrote:
> On Wed,  4 Nov 2015 20:19:33 +0300
> "Denis V. Lunev" <den@openvz.org> wrote:
>
>> this will make code better in the next patch
>>
> This changelog is not very useful. IMHO this calls for squashing this patch
> into the next one: then we clearly see how the return value is used and why
> the code is better.

is it principal to get the series merged?

In general I have a strong opinion that non-functional changes
should be separated from functional ones. This makes review
faster and allows to concentrate on things where we can have
mistakes.

Den

  reply	other threads:[~2015-11-05  8:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 17:19 [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes Denis V. Lunev
2015-11-04 17:19 ` [Qemu-devel] [PATCH 01/11] snapshot: create helper to test that block drivers supports snapshots Denis V. Lunev
2015-11-05  6:26   ` Greg Kurz
2015-11-05  7:58     ` Denis V. Lunev
2015-11-06 13:53     ` Stefan Hajnoczi
2015-11-04 17:19 ` [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name Denis V. Lunev
2015-11-05  7:55   ` Greg Kurz
2015-11-05  8:02     ` Denis V. Lunev [this message]
2015-11-04 17:19 ` [Qemu-devel] [PATCH 03/11] snapshot: create bdrv_all_delete_snapshot helper Denis V. Lunev
2015-11-06 14:09   ` Stefan Hajnoczi
2015-11-06 14:12     ` Denis V. Lunev
2015-11-07 12:22     ` Denis V. Lunev
2015-11-04 17:19 ` [Qemu-devel] [PATCH 04/11] snapshot: create bdrv_all_goto_snapshot helper Denis V. Lunev
2015-11-05  9:09   ` Greg Kurz
2015-11-04 17:19 ` [Qemu-devel] [PATCH 05/11] snapshot: create bdrv_all_find_snapshot helper Denis V. Lunev
2015-11-04 17:19 ` [Qemu-devel] [PATCH 06/11] migration: drop find_vmstate_bs check in hmp_delvm Denis V. Lunev
2015-11-04 17:19 ` [Qemu-devel] [PATCH 07/11] migration: reorder processing in hmp_savevm Denis V. Lunev
2015-11-04 17:19 ` [Qemu-devel] [PATCH 08/11] migration: implement bdrv_all_find_vmstate_bs and bdrv_unlock helpers Denis V. Lunev
2015-11-06 15:18   ` Stefan Hajnoczi
2015-11-06 15:23     ` Denis V. Lunev
2015-11-04 17:19 ` [Qemu-devel] [PATCH 09/11] migration: add missed aio_context_acquire for state writing/reading Denis V. Lunev
2015-11-06 15:37   ` Stefan Hajnoczi
2015-11-04 17:19 ` [Qemu-devel] [PATCH 10/11] snapshot: create bdrv_all_create_snapshot helper Denis V. Lunev
2015-11-04 17:19 ` [Qemu-devel] [PATCH 11/11] monitor: add missed aio_context_acquire into vm_completion call Denis V. Lunev
2015-11-06 15:40   ` Stefan Hajnoczi
2015-11-06 15:54 ` [Qemu-devel] [PATCH 2.5 v5 0/11] dataplane snapshot fixes Stefan Hajnoczi
2015-11-06 16:05   ` Eric Blake
2015-11-06 16:19     ` Denis V. Lunev
2015-11-06 17:29       ` Stefan Hajnoczi
2015-11-06 21:13     ` Denis V. Lunev
2015-11-09 21:05       ` Eric Blake
2015-11-10 12:55         ` Denis V. Lunev
2015-11-17  9:08 [Qemu-devel] [PATCH for 2.9 v8 0/10] " Denis V. Lunev
2015-11-17  9:08 ` [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name Denis V. Lunev
2015-11-18 10:59   ` Juan Quintela
2015-11-19  6:42 [Qemu-devel] [PATCH for 2.5 v10 0/10] dataplane snapshot fixes Denis V. Lunev
2015-11-19  6:42 ` [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563B0D0D.5070806@openvz.org \
    --to=den@openvz.org \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.