From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuGkJ-0004LK-07 for qemu-devel@nongnu.org; Thu, 05 Nov 2015 04:22:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuGkE-0004NM-8S for qemu-devel@nongnu.org; Thu, 05 Nov 2015 04:22:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuGkE-0004N4-3T for qemu-devel@nongnu.org; Thu, 05 Nov 2015 04:22:10 -0500 References: <1446551816-15768-1-git-send-email-zhang.zhanghailiang@huawei.com> <1446551816-15768-36-git-send-email-zhang.zhanghailiang@huawei.com> <563973C9.8000607@redhat.com> <563B08A0.7030802@huawei.com> <563B18DA.4090001@cn.fujitsu.com> From: Jason Wang Message-ID: <563B1FB7.5080002@redhat.com> Date: Thu, 5 Nov 2015 17:21:59 +0800 MIME-Version: 1.0 In-Reply-To: <563B18DA.4090001@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , zhanghailiang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, dgilbert@redhat.com, peter.huangpeng@huawei.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com On 11/05/2015 04:52 PM, Wen Congyang wrote: > On 11/05/2015 03:43 PM, zhanghailiang wrote: >> > Hi Jason, >> > >> > On 2015/11/4 10:56, Jason Wang wrote: >>> >> >>> >> >>> >> On 11/03/2015 07:56 PM, zhanghailiang wrote: >>>> >>> Signed-off-by: zhanghailiang >>>> >>> Cc: Jason Wang >>> >> >>> >> Commit log please. >>> >> >>>> >>> --- >>>> >>> v10: new patch >>>> >>> --- [...] >>>> >>> +} >>>> >>> +/* >>>> >>> +* This will be used by COLO or MC FT, for which they will need >>>> >>> +* to buffer all the packets of all VM's net devices, Here we check >>>> >>> +* and automatically add netfilter for netdev that doesn't attach any buffer >>>> >>> +* netfilter. >>>> >>> +*/ >>>> >>> +void qemu_auto_add_filter_buffer(NetFilterDirection direction, Error **errp) >>>> >>> +{ >>>> >>> + char *queue = g_strdup(NetFilterDirection_lookup[direction]); >>>> >>> + >>>> >>> + qemu_foreach_netdev(netdev_add_filter_buffer, queue, >>>> >>> + errp); >>>> >>> + g_free(queue); >>>> >>> +} >>>> >>> + >>> >> >>> >> This make me think for following questions: >>> >> >>> >> - What if a nic is hot added after this "automatically" filter add? > IIRC, we don't allow the user to hotplug a device when colo is running. > > Thanks > Wen Congyang > Even in the future? And how could forbid the user to do this, management? Thanks