From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZubZs-0005ZH-Ml
	for qemu-devel@nongnu.org; Fri, 06 Nov 2015 02:36:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZubZp-0002ny-5L
	for qemu-devel@nongnu.org; Fri, 06 Nov 2015 02:36:52 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:18989)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1ZubZo-0002n1-2d
	for qemu-devel@nongnu.org; Fri, 06 Nov 2015 02:36:49 -0500
References: <1446551816-15768-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1446551816-15768-2-git-send-email-zhang.zhanghailiang@huawei.com>
	<563B6D4B.1090107@redhat.com>
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
Message-ID: <563C5875.9050400@huawei.com>
Date: Fri, 6 Nov 2015 15:36:21 +0800
MIME-Version: 1.0
In-Reply-To: <563B6D4B.1090107@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH COLO-Frame v10 01/38] configure: Add
 parameter for configure to enable/disable COLO support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com

Hi Eric,

On 2015/11/5 22:52, Eric Blake wrote:
> On 11/03/2015 04:56 AM, zhanghailiang wrote:
>> configure --enable-colo/--disable-colo to switch COLO
>> support on/off.
>> COLO support is off by default.
>
> Off by default risks bit-rot for people not building it; it's generally
> best to default to off only if the feature requires dragging in extra
> libraries or similar build items not likely to be present in all
> development environments (and even then, auto-probing for required
> prerequisites is nicer than hard-coding off). Would on-by-default be a
> saner choice, or would that drag in too many extra dependencies for
> building?
>

In old version, which uses kernel proxy, we have to
install relevant nfnetlink libraries.

For the new version, we have dropped kernel proxy, so it is OK to turn it On by default.
I will fix it in next version :)

Thanks,
zhanghailiang