From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zain Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288 Date: Fri, 6 Nov 2015 18:27:33 +0800 Message-ID: <563C8095.30905@rock-chips.com> References: <1446772644-2352-1-git-send-email-zain.wang@rock-chips.com> <1446772644-2352-4-git-send-email-zain.wang@rock-chips.com> <4509145.eZ7GP0e6gb@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org To: Heiko Stuebner Return-path: In-Reply-To: <4509145.eZ7GP0e6gb@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-crypto.vger.kernel.org CgpPbiAyMDE15bm0MTHmnIgwNuaXpSAxODoxMiwgSGVpa28gU3R1ZWJuZXIgd3JvdGU6Cj4gQW0g RnJlaXRhZywgNi4gTm92ZW1iZXIgMjAxNSwgMDk6MTc6MjMgc2NocmllYiBaYWluIFdhbmc6Cj4+ IEFkZCBDcnlwdG8gZHJpdmVycyBmb3IgcmszMjg4IGluY2x1ZGluZyBjcnlwdG8gY29udHJvbGxl ciBhbmQgZG1hIGNsay4KPj4KPj4gU2lnbmVkLW9mZi1ieTogWmFpbiBXYW5nIDx6YWluLndhbmdA cm9jay1jaGlwcy5jb20+Cj4+IC0tLQo+Pgo+PiBDaGFuZ2VkIGluIHYyOgo+PiAtIE5vbmUKPj4K Pj4gQ2hhbmdlZCBpbiB2MToKPj4gLSByZW1vdmUgdGhlIF9jcnlwdG8gc3VmZml4Cj4+IC0gdXNl ICJyb2NrY2hpcCxyazMyODgtY3J5cHRvIiBpbnN0ZWFkIG9mICJyb2NrY2hpcCxyazMyODgiCj4+ Cj4+ICBhcmNoL2FybS9ib290L2R0cy9yazMyODguZHRzaSB8IDE1ICsrKysrKysrKysrKysrKwo+ PiAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2Fy Y2gvYXJtL2Jvb3QvZHRzL3JrMzI4OC5kdHNpIGIvYXJjaC9hcm0vYm9vdC9kdHMvcmszMjg4LmR0 c2kKPj4gaW5kZXggNmE3OWM5Yy4uN2I3OTE0ZSAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm0vYm9v dC9kdHMvcmszMjg4LmR0c2kKPj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvcmszMjg4LmR0c2kK Pj4gQEAgLTE3MCw2ICsxNzAsMjEgQEAKPj4gIAkJfTsKPj4gIAl9Owo+PiAgCj4+ICsJY3J5cHRv OiBjeXB0by1jb250cm9sbGVyQGZmOGEwMDAwIHsKPj4gKwkJY29tcGF0aWJsZSA9ICJyb2NrY2hp cCxyazMyODgtY3J5cHRvIjsKPj4gKwkJcmVnID0gPDB4ZmY4YTAwMDAgMHg0MDAwPjsKPj4gKwkJ aW50ZXJydXB0cyA9IDxHSUNfU1BJIDQ4IElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+PiArCQljbG9j a3MgPSA8JmNydSBBQ0xLX0NSWVBUTz4sCj4+ICsJCQkgPCZjcnUgSENMS19DUllQVE8+LAo+PiAr CQkJIDwmY3J1IFNDTEtfQ1JZUFRPPiwKPj4gKwkJCSA8JmNydSBBQ0xLX0RNQUMxPjsKPj4gKwkJ Y2xvY2stbmFtZXMgPSAiYWNsayIsCj4+ICsJCQkgICAgICAiaGNsayIsCj4+ICsJCQkgICAgICAi c2NsayIsCj4+ICsJCQkgICAgICAiYXBiX3BjbGsiOwo+PiArCQlzdGF0dXMgPSAib2theSI7Cj4+ ICsJfTsKPj4gKwo+IHBsZWFzZSBtb3ZlIHRoYXQgd2hvbGUgbm9kZSB0byB0aGUgcmlnaHQgbG9j YXRpb24uIEVudHJpZXMgYXJlIHNvcnRlZCBieSAKPiByZWdpc3RlciBhZGRyZXNzICh0aGUgZmY4 YTAwMDAgc2hvdWxkIHRoZW4gb2YgY291cnNlIGJlIGJlbG93ICBpMnNAZmY4OTAwMDAgCj4gYW5k IGFib3ZlIHZvcEBmZjkzMDAwMCkKb2shIGRvbmUhCj4KPgo+PiAgCXJlc2VydmVkLW1lbW9yeSB7 Cj4+ICAJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+PiAgCQkjc2l6ZS1jZWxscyA9IDwxPjsKPj4K Pgo+Cj4KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1y b2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033177AbbKFK1y (ORCPT ); Fri, 6 Nov 2015 05:27:54 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:59869 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032054AbbKFK1u (ORCPT ); Fri, 6 Nov 2015 05:27:50 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zain.wang@rock-chips.com X-FST-TO: eddie.cai@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zain.wang@rock-chips.com X-UNIQUE-TAG: <6ae889d09e0cff7dd2542929f2269de8> X-DNS-TYPE: 0 Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288 To: Heiko Stuebner References: <1446772644-2352-1-git-send-email-zain.wang@rock-chips.com> <1446772644-2352-4-git-send-email-zain.wang@rock-chips.com> <4509145.eZ7GP0e6gb@phil> Cc: zhengsq@rock-chips.com, hl@rock-chips.com, herbert@gondor.apana.org.au, davem@davemloft.net, mturquette@baylibre.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, robh+dt@kernel.org, galak@codeaurora.org, linux@arm.linux.org.uk, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, eddie.cai@rock-chips.com From: Zain Message-ID: <563C8095.30905@rock-chips.com> Date: Fri, 6 Nov 2015 18:27:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <4509145.eZ7GP0e6gb@phil> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年11月06日 18:12, Heiko Stuebner wrote: > Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang: >> Add Crypto drivers for rk3288 including crypto controller and dma clk. >> >> Signed-off-by: Zain Wang >> --- >> >> Changed in v2: >> - None >> >> Changed in v1: >> - remove the _crypto suffix >> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288" >> >> arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi >> index 6a79c9c..7b7914e 100644 >> --- a/arch/arm/boot/dts/rk3288.dtsi >> +++ b/arch/arm/boot/dts/rk3288.dtsi >> @@ -170,6 +170,21 @@ >> }; >> }; >> >> + crypto: cypto-controller@ff8a0000 { >> + compatible = "rockchip,rk3288-crypto"; >> + reg = <0xff8a0000 0x4000>; >> + interrupts = ; >> + clocks = <&cru ACLK_CRYPTO>, >> + <&cru HCLK_CRYPTO>, >> + <&cru SCLK_CRYPTO>, >> + <&cru ACLK_DMAC1>; >> + clock-names = "aclk", >> + "hclk", >> + "sclk", >> + "apb_pclk"; >> + status = "okay"; >> + }; >> + > please move that whole node to the right location. Entries are sorted by > register address (the ff8a0000 should then of course be below i2s@ff890000 > and above vop@ff930000) ok! done! > > >> reserved-memory { >> #address-cells = <1>; >> #size-cells = <1>; >> > > >