From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V3 2/4] dma: add Qualcomm Technologies HIDMA management driver Date: Sun, 8 Nov 2015 21:17:20 -0500 Message-ID: <56400230.8030303@codeaurora.org> References: <1446958380-23298-1-git-send-email-okaya@codeaurora.org> <1446958380-23298-3-git-send-email-okaya@codeaurora.org> <563ED8DF.6090307@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35794 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201AbbKICR1 (ORCPT ); Sun, 8 Nov 2015 21:17:27 -0500 In-Reply-To: <563ED8DF.6090307@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Timur Tabi , dmaengine@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com Cc: agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Vinod Koul , Dan Williams , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org On 11/8/2015 12:08 AM, Timur Tabi wrote: On 11/8/2015 12:08 AM, Timur Tabi wrote: > Sinan Kaya wrote: >> + val = val & ~(MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS); >> + val = val | (mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS); >> + val = val & ~(MAX_BUS_REQ_LEN_MASK); >> + val = val | (mgmtdev->max_read_request); > > val &= ~MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS; > val |= mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS; > val &= ~MAX_BUS_REQ_LEN_MASK; > val |= mgmtdev->max_read_request; > >> +static const struct of_device_id hidma_mgmt_match[] = { >> + { .compatible = "qcom,hidma-mgmt", }, >> + { .compatible = "qcom,hidma-mgmt-1.0", }, >> + { .compatible = "qcom,hidma-mgmt-1.1", }, >> + {}, >> +}; > > I thought Rob said that he did NOT want to use version numbers in > compatible strings. And what's the difference between these three > versions anyway? > This was already discussed here. https://lkml.org/lkml/2015/11/2/689 The agreement was to use compatible = "qcom,hidma-mgmt-1.1", "qcom,hidma-mgmt-1.0", "qcom,hidma-mgmt"; I'll be adding code for v1.1 specifically in the future. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Sun, 8 Nov 2015 21:17:20 -0500 Subject: [PATCH V3 2/4] dma: add Qualcomm Technologies HIDMA management driver In-Reply-To: <563ED8DF.6090307@codeaurora.org> References: <1446958380-23298-1-git-send-email-okaya@codeaurora.org> <1446958380-23298-3-git-send-email-okaya@codeaurora.org> <563ED8DF.6090307@codeaurora.org> Message-ID: <56400230.8030303@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/8/2015 12:08 AM, Timur Tabi wrote: On 11/8/2015 12:08 AM, Timur Tabi wrote: > Sinan Kaya wrote: >> + val = val & ~(MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS); >> + val = val | (mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS); >> + val = val & ~(MAX_BUS_REQ_LEN_MASK); >> + val = val | (mgmtdev->max_read_request); > > val &= ~MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS; > val |= mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS; > val &= ~MAX_BUS_REQ_LEN_MASK; > val |= mgmtdev->max_read_request; > >> +static const struct of_device_id hidma_mgmt_match[] = { >> + { .compatible = "qcom,hidma-mgmt", }, >> + { .compatible = "qcom,hidma-mgmt-1.0", }, >> + { .compatible = "qcom,hidma-mgmt-1.1", }, >> + {}, >> +}; > > I thought Rob said that he did NOT want to use version numbers in > compatible strings. And what's the difference between these three > versions anyway? > This was already discussed here. https://lkml.org/lkml/2015/11/2/689 The agreement was to use compatible = "qcom,hidma-mgmt-1.1", "qcom,hidma-mgmt-1.0", "qcom,hidma-mgmt"; I'll be adding code for v1.1 specifically in the future. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project