From: Guenter Roeck <linux@roeck-us.net>
To: Alexander Stein <alexander.stein@systec-electronic.com>,
Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 1/2] watchdog: gpio-wdt: Rename notifier to reboot_notifier
Date: Mon, 9 Nov 2015 07:12:03 -0800 [thread overview]
Message-ID: <5640B7C3.308@roeck-us.net> (raw)
In-Reply-To: <1447062944-12296-1-git-send-email-alexander.stein@systec-electronic.com>
On 11/09/2015 01:55 AM, Alexander Stein wrote:
> This is a preparation before adding a panic notifier.
>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/gpio_wdt.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watchdog/gpio_wdt.c
> index 90d59d3f..c7b8a06 100644
> --- a/drivers/watchdog/gpio_wdt.c
> +++ b/drivers/watchdog/gpio_wdt.c
> @@ -36,7 +36,7 @@ struct gpio_wdt_priv {
> unsigned int hw_algo;
> unsigned int hw_margin;
> unsigned long last_jiffies;
> - struct notifier_block notifier;
> + struct notifier_block reboot_notifier;
> struct timer_list timer;
> struct watchdog_device wdd;
> };
> @@ -130,7 +130,7 @@ static int gpio_wdt_notify_sys(struct notifier_block *nb, unsigned long code,
> void *unused)
> {
> struct gpio_wdt_priv *priv = container_of(nb, struct gpio_wdt_priv,
> - notifier);
> + reboot_notifier);
>
> mod_timer(&priv->timer, 0);
>
> @@ -228,8 +228,8 @@ static int gpio_wdt_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - priv->notifier.notifier_call = gpio_wdt_notify_sys;
> - ret = register_reboot_notifier(&priv->notifier);
> + priv->reboot_notifier.notifier_call = gpio_wdt_notify_sys;
> + ret = register_reboot_notifier(&priv->reboot_notifier);
> if (ret)
> goto error_unregister;
>
> @@ -248,7 +248,7 @@ static int gpio_wdt_remove(struct platform_device *pdev)
> struct gpio_wdt_priv *priv = platform_get_drvdata(pdev);
>
> del_timer_sync(&priv->timer);
> - unregister_reboot_notifier(&priv->notifier);
> + unregister_reboot_notifier(&priv->reboot_notifier);
> watchdog_unregister_device(&priv->wdd);
>
> return 0;
>
next prev parent reply other threads:[~2015-11-09 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 9:55 [PATCH 1/2] watchdog: gpio-wdt: Rename notifier to reboot_notifier Alexander Stein
2015-11-09 9:55 ` [PATCH 2/2] watchdog: gpio-wdt: Add panic notifier Alexander Stein
2015-11-09 15:19 ` Guenter Roeck
2015-11-09 15:46 ` Alexander Stein
2015-11-09 19:02 ` Uwe Kleine-König
2015-11-09 23:19 ` Guenter Roeck
2015-11-10 7:20 ` Uwe Kleine-König
2015-11-13 18:44 ` Guenter Roeck
2015-11-09 15:12 ` Guenter Roeck [this message]
2015-11-23 5:33 ` [PATCH 1/2] watchdog: gpio-wdt: Rename notifier to reboot_notifier Guenter Roeck
2015-11-23 13:29 ` Alexander Stein
2015-11-23 16:02 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640B7C3.308@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexander.stein@systec-electronic.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.