From: "Ian McDonald" <ian.mcdonald@jandi.co.nz>
To: "Tejun Heo" <htejun@gmail.com>
Cc: "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>,
gregkh@suse.de,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jeff Garzik" <jeff@garzik.org>
Subject: Re: [PATCH] pci: allow multiple calls to pcim_pin_device()
Date: Wed, 21 Feb 2007 10:45:35 +1300 [thread overview]
Message-ID: <5640c7e00702201345n409d5c4btf978610541f866c2@mail.gmail.com> (raw)
In-Reply-To: <20070220082839.GN1625@htj.dyndns.org>
On 2/20/07, Tejun Heo <htejun@gmail.com> wrote:
> Sanity check in pcim_pin_device() was too restrictive in that it
> didn't allow multiple calls to the function, which is against the
> devres philosohpy of fire-and-forget. Track pinned status separately
> and allow pinning multiple times.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> It was an actual bug in pcim_pin_device() implementation. Thanks for
> spotting this. :-)
>
> Ian McDonald, please verify your warning goes away with this patch.
Yes it does. Thanks for sorting.
>
> Greg, please forward this patch upstream once Ian acks it.
>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
--
Web: http://wand.net.nz/~iam4
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group
prev parent reply other threads:[~2007-02-20 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-18 19:53 [BUG/WARN] Error initialising drivers in PCI Ian McDonald
2007-02-18 20:58 ` Bartlomiej Zolnierkiewicz
2007-02-19 4:00 ` Ian McDonald
2007-02-19 11:47 ` Bartlomiej Zolnierkiewicz
2007-02-20 8:28 ` [PATCH] pci: allow multiple calls to pcim_pin_device() Tejun Heo
2007-02-20 21:45 ` Ian McDonald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640c7e00702201345n409d5c4btf978610541f866c2@mail.gmail.com \
--to=ian.mcdonald@jandi.co.nz \
--cc=bzolnier@gmail.com \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.