From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Subject: Re: [PATCH v2 1/6] gitignore: Ignore *.orig, *.rej and *.swp files Date: Mon, 9 Nov 2015 21:22:16 +0100 Message-ID: <56410078.4070407__31467.040666803$1447100641$gmane$org@gmail.com> References: <1437402954-7375-1-git-send-email-daniel.kiper@oracle.com> <1437402954-7375-2-git-send-email-daniel.kiper@oracle.com> <1439370297.9747.318.camel@citrix.com> <20151109152956.GE26902@olila.local.net-space.pl> <5640BCFC.6090106@gmail.com> <20151109153936.GF26902@olila.local.net-space.pl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4889820506207109143==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZvsxQ-0000BO-32 for xen-devel@lists.xenproject.org; Mon, 09 Nov 2015 20:22:28 +0000 Received: by wmec201 with SMTP id c201so86579474wme.1 for ; Mon, 09 Nov 2015 12:22:26 -0800 (PST) In-Reply-To: <20151109153936.GF26902@olila.local.net-space.pl> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel Kiper Cc: jgross@suse.com, grub-devel@gnu.org, keir@xen.org, Ian Campbell , stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, wei.liu2@citrix.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============4889820506207109143== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0KvS5GE5d1XXoXwegxwACsXu3reaoShlq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0KvS5GE5d1XXoXwegxwACsXu3reaoShlq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09.11.2015 16:39, Daniel Kiper wrote: > On Mon, Nov 09, 2015 at 04:34:20PM +0100, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: >> On 09.11.2015 16:29, Daniel Kiper wrote: >>> On Wed, Nov 04, 2015 at 01:03:56PM +0100, Vladimir 'phcoder' Serbinen= ko wrote: >>>> Le 12 ao=C3=BBt 2015 11:04 AM, "Ian Campbell" a =C3=A9crit : >>>>> >>>>> >>>>> (Having written the below I see too late that this is a grub patch = not a >>>>> Xen one, a tag in the subject for such cross posted patches would b= e >>>> useful >>>>> please. Anyway, my opinion counts for very little in this context b= ut I >>>>> leave it below since already I wrote it. I notice that xen.git#.git= ignore >>>>> _does_ list *.rej, which I think is wrong...) >>>>> >>>>> On Mon, 2015-07-20 at 16:35 +0200, Daniel Kiper wrote: >>>>>> Signed-off-by: Daniel Kiper >>>>> >>>>> At least *.rej and perhaps *.orig are indicative of a failed patch >>>>> application, I think I want them to appear in "git status". >>>>> >>>>> By way of comparison Linux's .gitignore includes *.orig but not *.r= ej and >>>>> Qemu's includes neither. >>>>> >>>>> So nack to the addition of *.rej from me. I'm more or less ambivale= nt >>>> about >>>>> *.orig. >>>>> >>>> I have to agree. You should clean up *.rej *.orig after fixing confl= icts >>> >>> Thanks for comment on this. Could you review rest of this patchset? >>> I am working on v3 and it will be nice to take your (and others if >>> possible) comments into it. >>> >> I will go through them today >=20 > Thanks a lot! >=20 All reviewed. Some of them already good but they have dependencies. Feel free to either fix concerns with dependencies or rebase in a way to get the good ones committed first in a meaningful way > Daniel >=20 --0KvS5GE5d1XXoXwegxwACsXu3reaoShlq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlZBAHgACgkQmBXlbbo5nOtJjwD/aX6TMQE0ZlHesRPbK9cMD/rx q6TLcVKDdvTG1j76bpQBAKCh1qMDUZnNoP1AqQGa04uA/iOCWvLizGErIuSyz5N0 =GrAa -----END PGP SIGNATURE----- --0KvS5GE5d1XXoXwegxwACsXu3reaoShlq-- --===============4889820506207109143== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4889820506207109143==--