From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbbKIVis (ORCPT ); Mon, 9 Nov 2015 16:38:48 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:58535 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbbKIVir (ORCPT ); Mon, 9 Nov 2015 16:38:47 -0500 Subject: Re: [PATCH] ASoC: davinci-mcasp: Fix TDM slot rx/tx mask associations To: Andreas Dannenberg , Liam Girdwood , Mark Brown , Peter Ujfalusi References: <1447093159-32294-1-git-send-email-dannenberg@ti.com> CC: Misael Lopez Cruz , , , From: Jyri Sarha Message-ID: <5641125E.5030804@ti.com> Date: Mon, 9 Nov 2015 23:38:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447093159-32294-1-git-send-email-dannenberg@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Jyri Sarha For what little there is to review. I only had HW that worked with symmetric masks, so I did not hit this myself. Should have hacked something to codec end to be able to test asymetric masks at McASP end. Thanks, Jyri On 11/09/15 20:19, Andreas Dannenberg wrote: > Fixes the associations between the tx_mask and rx_mask and the associated > playback / capture streams during setting of the TDM slot. With this > patch in place it is now possible for example to only populate tx_mask > (leaving rx_mask as 0) for output-only codecs to control the TDM slot(s) > the McASP serial port uses for transmit. Before that, this scenario > would incorrectly rely on the rx_mask for this. > > Signed-off-by: Andreas Dannenberg > --- > sound/soc/davinci/davinci-mcasp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c > index 4495a40..caa0beb 100644 > --- a/sound/soc/davinci/davinci-mcasp.c > +++ b/sound/soc/davinci/davinci-mcasp.c > @@ -681,8 +681,8 @@ static int davinci_mcasp_set_tdm_slot(struct snd_soc_dai *dai, > } > > mcasp->tdm_slots = slots; > - mcasp->tdm_mask[SNDRV_PCM_STREAM_PLAYBACK] = rx_mask; > - mcasp->tdm_mask[SNDRV_PCM_STREAM_CAPTURE] = tx_mask; > + mcasp->tdm_mask[SNDRV_PCM_STREAM_PLAYBACK] = tx_mask; > + mcasp->tdm_mask[SNDRV_PCM_STREAM_CAPTURE] = rx_mask; > mcasp->slot_width = slot_width; > > return davinci_mcasp_set_ch_constraints(mcasp); > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jyri Sarha Subject: Re: [PATCH] ASoC: davinci-mcasp: Fix TDM slot rx/tx mask associations Date: Mon, 9 Nov 2015 23:38:38 +0200 Message-ID: <5641125E.5030804@ti.com> References: <1447093159-32294-1-git-send-email-dannenberg@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447093159-32294-1-git-send-email-dannenberg@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Andreas Dannenberg , Liam Girdwood , Mark Brown , Peter Ujfalusi Cc: Misael Lopez Cruz , linux-omap@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org Reviewed-by: Jyri Sarha For what little there is to review. I only had HW that worked with symmetric masks, so I did not hit this myself. Should have hacked something to codec end to be able to test asymetric masks at McASP end. Thanks, Jyri On 11/09/15 20:19, Andreas Dannenberg wrote: > Fixes the associations between the tx_mask and rx_mask and the associated > playback / capture streams during setting of the TDM slot. With this > patch in place it is now possible for example to only populate tx_mask > (leaving rx_mask as 0) for output-only codecs to control the TDM slot(s) > the McASP serial port uses for transmit. Before that, this scenario > would incorrectly rely on the rx_mask for this. > > Signed-off-by: Andreas Dannenberg > --- > sound/soc/davinci/davinci-mcasp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c > index 4495a40..caa0beb 100644 > --- a/sound/soc/davinci/davinci-mcasp.c > +++ b/sound/soc/davinci/davinci-mcasp.c > @@ -681,8 +681,8 @@ static int davinci_mcasp_set_tdm_slot(struct snd_soc_dai *dai, > } > > mcasp->tdm_slots = slots; > - mcasp->tdm_mask[SNDRV_PCM_STREAM_PLAYBACK] = rx_mask; > - mcasp->tdm_mask[SNDRV_PCM_STREAM_CAPTURE] = tx_mask; > + mcasp->tdm_mask[SNDRV_PCM_STREAM_PLAYBACK] = tx_mask; > + mcasp->tdm_mask[SNDRV_PCM_STREAM_CAPTURE] = rx_mask; > mcasp->slot_width = slot_width; > > return davinci_mcasp_set_ch_constraints(mcasp); >