From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v3 2/2] vhost: Add VHOST PMD
Date: Tue, 10 Nov 2015 12:14:19 +0900
Message-ID: <5641610B.30107@igel.co.jp>
References: <1446436737-25606-2-git-send-email-mukawa@igel.co.jp>
 <1447046221-20811-1-git-send-email-mukawa@igel.co.jp>
 <1447046221-20811-3-git-send-email-mukawa@igel.co.jp>
 <20151109142205.4040ec07@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 8226B591F
 for <dev@dpdk.org>; Tue, 10 Nov 2015 04:14:23 +0100 (CET)
Received: by pasz6 with SMTP id z6so226315714pas.2
 for <dev@dpdk.org>; Mon, 09 Nov 2015 19:14:22 -0800 (PST)
In-Reply-To: <20151109142205.4040ec07@xeon-e3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/11/10 7:22, Stephen Hemminger wrote:
> On Mon,  9 Nov 2015 14:17:01 +0900
> Tetsuya Mukawa <mukawa@igel.co.jp> wrote:
>
>> +	rte_atomic32_set(&r->while_queuing, 1);
>> +
>> +	if (unlikely(rte_atomic32_read(&r->allow_queuing) == 0))
>> +		goto out;
> You special 2 variable custom locking here is buggy.
> If you hit second atomic test, you will leave while_queuing set.

Hi Stephen,

Thanks for reviewing.
I clear while_queuing like below.

+out:
+	rte_atomic32_set(&r->while_queuing, 0);
+
+	return nb_rx;
+}

Thanks,
tetsuya