On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote: > this patch is very much be meaningful after next patch which adds multiple > gluster servers support. After that, > > an example is, in 'servers' tuple values we use 'server' variable for key > 'host' in the code, it will be quite messy to have colliding names for > variables, so to maintain better readability and makes it consistent with other > existing code as well as the input keys/options, this patch renames the > following variables > 'server' -> 'host' > 'image' -> 'path' > 'volname' -> 'volume' > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 54 +++++++++++++++++++++++++++--------------------------- > 1 file changed, 27 insertions(+), 27 deletions(-) When this has been previously positively reviewed, and you are making no further changes to the code, it speeds up review to add the reviewer's line to your commit message (so that the reviewer knows it is unchanged, and so that other readers know it has been reviewed at least once). Of course, if you change a patch, dropping the R-b line is appropriate. My review from https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04916.html still stands, so that would mean adding: Reviewed-by: Eric Blake to the commit body if you have a reason to post v14 of this series. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org