From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCe1-0003vO-Nr for qemu-devel@nongnu.org; Tue, 10 Nov 2015 12:23:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwCdy-0002s1-K5 for qemu-devel@nongnu.org; Tue, 10 Nov 2015 12:23:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCdy-0002ru-CS for qemu-devel@nongnu.org; Tue, 10 Nov 2015 12:23:42 -0500 References: <1447164879-6756-1-git-send-email-stefanha@redhat.com> <1447164879-6756-34-git-send-email-stefanha@redhat.com> From: Eric Blake Message-ID: <56422818.601@redhat.com> Date: Tue, 10 Nov 2015 10:23:36 -0700 MIME-Version: 1.0 In-Reply-To: <1447164879-6756-34-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jWSqI9P7NpQJUipTIdTD1kKxLRV1QV0ut" Subject: Re: [Qemu-devel] [PULL 33/44] block: New option to define the intervals for collecting I/O statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Peter Maydell , Alberto Garcia This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jWSqI9P7NpQJUipTIdTD1kKxLRV1QV0ut Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/10/2015 07:14 AM, Stefan Hajnoczi wrote: > From: Alberto Garcia >=20 > The BlockAcctStats structure contains a list of BlockAcctTimedStats. > Each one of these collects statistics about the minimum, maximum and > average latencies of all I/O operations in a certain interval of time. >=20 > This patch adds a new "stats-intervals" option that allows defining > these intervals. >=20 > Signed-off-by: Alberto Garcia > Message-id: 41cbcd334a61c6157f0f495cdfd21eff6c156f2a.1446044837.git.ber= to@igalia.com > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 37 +++++++++++++++++++++++++++++++++++++ > qapi/block-core.json | 4 ++++ > 2 files changed, 41 insertions(+) > +++ b/qapi/block-core.json > @@ -1503,6 +1503,9 @@ > # @stats-account-failed: #optional whether to include failed > # operations when computing latency and last > # access statistics (default: true) (Since 2.5= ) > +# @stats-intervals: #optional colon-separated list of intervals for > +# collecting I/O statistics, in seconds (default: no= ne) > +# (Since 2.5) Eww. Sorry for not noticing this sooner, but can we please fix this to be= : '*stats-intervals':['int'] Having to post-process parse for colons means that the JSON interface was not properly defined. I'm okay if the fix is a followup, but we need to get it in before 2.5 bakes in the gross interface. > # @detect-zeroes: #optional detect and optimize zero writes (Since 2.1= ) > # (default: off) > # > @@ -1520,6 +1523,7 @@ > '*read-only': 'bool', > '*stats-account-invalid': 'bool', > '*stats-account-failed': 'bool', > + '*stats-intervals': 'str', > '*detect-zeroes': 'BlockdevDetectZeroesOptions' } } > =20 > ## >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jWSqI9P7NpQJUipTIdTD1kKxLRV1QV0ut Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQigYAAoJEKeha0olJ0Nqr0oH/RmkxGGda6YITDXOdVNXiIN+ ovBM5wGToPNgg3Lonl90b6J7Yd9zry9/qRLuw4PJR6m7TXl/xPOZyiQpdcTMhCX+ eZn47FYF207z1KUsRTKAB5E69cOHCI4thZ/frOlO0EwlLrlxXfBZ/liUHe/xeZV4 nD9l8O3sUW7WENBtuAq0D9FfWDRGGDbNAT+q543c4d+27bvbwVNuMjmUzGDAs/E2 VrlnfuQypD/u8XH28gWxawuiu0i/+j3vAFGT7gKzwv2VIblWyMz28wJn+0O5M54Z VsyQ3mK3dfyCuNjarRcgZf3GnqzkFFqB2I5TCMYmFSDx1xCzCiEKwzFheYzTg/k= =P0Zp -----END PGP SIGNATURE----- --jWSqI9P7NpQJUipTIdTD1kKxLRV1QV0ut--