From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwY7X-0006pi-6e for qemu-devel@nongnu.org; Wed, 11 Nov 2015 11:19:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwY7T-0001xn-9A for qemu-devel@nongnu.org; Wed, 11 Nov 2015 11:19:39 -0500 References: <1447224690-9743-1-git-send-email-eblake@redhat.com> <1447224690-9743-19-git-send-email-eblake@redhat.com> <87si4cboqt.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56436A90.3010301@redhat.com> Date: Wed, 11 Nov 2015 09:19:28 -0700 MIME-Version: 1.0 In-Reply-To: <87si4cboqt.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qWfhMbCr65fqgR8nO9sv5qoBofC2fFI9O" Subject: Re: [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , Jiri Pirko , Eduardo Habkost , "open list:Block layer core" , "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Scott Feldman , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qWfhMbCr65fqgR8nO9sv5qoBofC2fFI9O Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/11/2015 07:21 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in >> since c6bd8c706. Nuke them. >=20 > Doesn't really belong to this series, but that's okay. If you're going to modify this for 2.5 inclusion through your qerror tree, you may want to change the description to: A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) were missed in c6bd8c706, or have snuck in since. Nuke them. >> +++ b/hw/i386/pc.c >> @@ -1795,7 +1795,7 @@ static void pc_machine_set_max_ram_below_4g(Obje= ct *obj, Visitor *v, >> return; >> } >> if (value > (1ULL << 32)) { >> - error_set(&error, ERROR_CLASS_GENERIC_ERROR, >> + error_setg(&error, >> "Machine option 'max-ram-below-4g=3D%"PRIu64 >> "' expects size less than or equal to 4G", value); >=20 > Indentation is now off. Can tidy up in my tree. >=20 >> error_propagate(errp, error); > [Rest snipped, it looks good] >=20 There's also the question if we want to address the ErrorClass name munging of 19/28 by adding your idea of an aliasing typedef in error.h; if so, should I prepare a smaller patch series of both of those changes for consideration for 2.5? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qWfhMbCr65fqgR8nO9sv5qoBofC2fFI9O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQ2qQAAoJEKeha0olJ0Nqb0IIAJE1isTlCvqv+hMjURQh5J3i DqcOCZ/HoQyLF4kPB8U3Vw3U+kkLQBZ8dwReRVBoQLHxPWujUn/200oW3qa/QWco O4iIRyXFaT8UmygDSczkpXOb6N86RgpVzj40A5pYiAIIOVOtXJAcUs6rYHR6mS/E phi7/QCW6EhL8hB/B6l7DRlylPM8EXawLMeCUNSBuHP0h8z5DRx9IlHji0dn+X57 +MEo2rixGz06aws1A/M4g4yrcwxXI55Upm4+6GTjQz+PU5h3vCqqUK80l6yAINAq psykEF3ICnjTCkm0kCqfm7G0SMU2JkxahFJN5EA5XHPawEG8g0VopLT731NZ3iA= =j9g+ -----END PGP SIGNATURE----- --qWfhMbCr65fqgR8nO9sv5qoBofC2fFI9O--