From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: Runtime services support for Xen on ARM
Date: Thu, 12 Nov 2015 04:04:45 -0700
Message-ID: <5644805D02000078000B42B2@prv-mh.provo.novell.com>
References: <5641D5F0.5080401@huawei.com>
	<alpine.DEB.2.02.1511101210580.5676@kaball.uk.xensource.com>
	<1447158988.9407.30.camel@citrix.com> <5644569A.80202@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1ZwpgR-0003VH-2U
	for xen-devel@lists.xenproject.org; Thu, 12 Nov 2015 11:04:53 +0000
In-Reply-To: <5644569A.80202@huawei.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Shannon Zhao <shannon.zhao@linaro.org>, Ian Campbell <ian.campbell@citrix.com>, Christoffer Dall <christoffer.dall@linaro.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 12.11.15 at 10:06, <zhaoshenglong@huawei.com> wrote:
> Today I try the way you suggested. Set USE_SET_VIRTUAL_ADDRESS_MAP on
> ARM and make a fake efi_rs_enter() and efi_rs_leave(). But when calling
> efi_init_memory, it fails with below log:

You can't just #define that constant and assume things will work: This
code is there so far only for documentation purposes. You need to go
look what parts of it may have bitrotted.

> It fails at below line:
> 
>     efi_rs->SetVirtualAddressMap(efi_memmap_size, efi_mdesc_size,
>                                  mdesc_ver, efi_memmap);

Quite obviously because efi_exit_boot() now sets efi_bs to NULL.

Jan