From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: Runtime services support for Xen on ARM Date: Thu, 12 Nov 2015 20:52:10 +0800 Message-ID: <56448B7A.4070207@linaro.org> References: <5641D5F0.5080401@huawei.com> <1447158988.9407.30.camel@citrix.com> <5644569A.80202@huawei.com> <5644805D02000078000B42B2@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZwrMP-0003xP-Ci for xen-devel@lists.xenproject.org; Thu, 12 Nov 2015 12:52:17 +0000 Received: by wmec201 with SMTP id c201so89908113wme.1 for ; Thu, 12 Nov 2015 04:52:13 -0800 (PST) In-Reply-To: <5644805D02000078000B42B2@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Shannon Zhao Cc: xen-devel , Ian Campbell , Christoffer Dall , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 2015/11/12 19:04, Jan Beulich wrote: >>>> On 12.11.15 at 10:06, wrote: >> Today I try the way you suggested. Set USE_SET_VIRTUAL_ADDRESS_MAP on >> ARM and make a fake efi_rs_enter() and efi_rs_leave(). But when calling >> efi_init_memory, it fails with below log: > > You can't just #define that constant and assume things will work: This > code is there so far only for documentation purposes. You need to go > look what parts of it may have bitrotted. > >> It fails at below line: >> >> efi_rs->SetVirtualAddressMap(efi_memmap_size, efi_mdesc_size, >> mdesc_ver, efi_memmap); > > Quite obviously because efi_exit_boot() now sets efi_bs to NULL. > I see in efi_start() there is below code setting efi_bs to NULL. But here it calls efi_rs not efi_bs. I don't understand the relation of them. status = SystemTable->BootServices->ExitBootServices(ImageHandle, map_key); efi_bs = NULL; -- Shannon