From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Zwua8-0005do-0W
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 11:18:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Zwua4-0002R7-Si
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 11:18:39 -0500
Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:35904)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Zwua4-0002Qt-MR
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 11:18:36 -0500
Received: by wmww144 with SMTP id w144so207462256wmw.1
	for <qemu-devel@nongnu.org>; Thu, 12 Nov 2015 08:18:36 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <COL130-W26C8810524FA22F97ACDECB9160@phx.gbl>
	<COL130-W319D6675665F237C58622EB9160@phx.gbl>
	<5644A3E5.1040904@twiddle.net>
	<BLU437-SMTP825879E16C5695A00D3B62B9120@phx.gbl>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <5644BBD7.4090109@twiddle.net>
Date: Thu, 12 Nov 2015 17:18:31 +0100
MIME-Version: 1.0
In-Reply-To: <BLU437-SMTP825879E16C5695A00D3B62B9120@phx.gbl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] target-tilegx: Implement fpu single
 floating point
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Gang <xili_gchen_5257@hotmail.com>, Peter Maydell <peter.maydell@linaro.org>, Chris Metcalf <cmetcalf@ezchip.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 11/12/2015 05:12 PM, Chen Gang wrote:
> On 11/12/15 22:36, Richard Henderson wrote:
>>> +    if (sfmt.calc == TILEGX_F_CALC_CVT) {
>>> +        if (sfmt.sign)
>>> +            f.f = int32_to_float32(0 - sfmt.mantissa, fp_status);
>>> +        else
>>> +            f.f = uint32_to_float32(sfmt.mantissa, fp_status);
>>> +    } else {
>>
>> Formatting.
>>
>> You really should know better by now.
>> I'm not even going to look at the rest.
>>
>
> Excuse me, my English is not quite well, I am not quite understand your
> meaning.
>
> Does the code above have issues?
>

Please read ./CODING_STYLE, and use ./scripts/checkpatch.pl.


r~