Re: Runtime services support for Xen on ARM

From: "Jan Beulich" <JBeulich@suse.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>,
	Shannon Zhao <shannon.zhao@linaro.org>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: Runtime services support for Xen on ARM
Date: Thu, 12 Nov 2015 08:29:27 -0700	[thread overview]
Message-ID: <5644BE6702000078000B4520@prv-mh.provo.novell.com> (raw)
In-Reply-To: <56448B7A.4070207@linaro.org>

>>> On 12.11.15 at 13:52, <shannon.zhao@linaro.org> wrote:
> On 2015/11/12 19:04, Jan Beulich wrote:
>>>>> On 12.11.15 at 10:06, <zhaoshenglong@huawei.com> wrote:
>>> Today I try the way you suggested. Set USE_SET_VIRTUAL_ADDRESS_MAP on
>>> ARM and make a fake efi_rs_enter() and efi_rs_leave(). But when calling
>>> efi_init_memory, it fails with below log:
>>
>> You can't just #define that constant and assume things will work: This
>> code is there so far only for documentation purposes. You need to go
>> look what parts of it may have bitrotted.
>>
>>> It fails at below line:
>>>
>>>      efi_rs->SetVirtualAddressMap(efi_memmap_size, efi_mdesc_size,
>>>                                   mdesc_ver, efi_memmap);
>>
>> Quite obviously because efi_exit_boot() now sets efi_bs to NULL.
>>
> I see in efi_start() there is below code setting efi_bs to NULL. But 
> here it calls efi_rs not efi_bs. I don't understand the relation of them.

Oh, sorry, my mistake. I guess I'd better not comment on ARM
crashes...

Jan