From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwv1t-0007R4-T9 for qemu-devel@nongnu.org; Thu, 12 Nov 2015 11:47:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwv1p-0004JH-Ti for qemu-devel@nongnu.org; Thu, 12 Nov 2015 11:47:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwv1p-0004Ir-Og for qemu-devel@nongnu.org; Thu, 12 Nov 2015 11:47:17 -0500 References: <1447345789-840-1-git-send-email-jsnow@redhat.com> From: Laurent Vivier Message-ID: <5644C291.7080302@redhat.com> Date: Thu, 12 Nov 2015 17:47:13 +0100 MIME-Version: 1.0 In-Reply-To: <1447345789-840-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: check for $cxx before use List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 12/11/2015 17:29, John Snow wrote: > I broke this when adding checks for clang++. > > Reported-by: Laurent Vivier > Signed-off-by: John Snow > > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 46fd8bd..f75df4b 100755 > --- a/configure > +++ b/configure > @@ -4435,7 +4435,8 @@ fi > if test "$fortify_source" != "no"; then > if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then > fortify_source="no"; > - elif echo | $cxx -dM -E - | grep __clang__ > /dev/null 2>&1 ; then > + elif test -n "$cxx" && > + echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then > fortify_source="no"; > else > fortify_source="yes" > This fixes the problem: no more error message. Thanks, Laurent