All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Matt Gingell <gingell@google.com>, kvm@vger.kernel.org
Cc: Steve Rutherford <srutherford@google.com>
Subject: Re: [PATCH 2/3] KVM: x86: request interrupt window when IRQ chip is split
Date: Fri, 13 Nov 2015 09:56:00 +0100	[thread overview]
Message-ID: <5645A5A0.30701@redhat.com> (raw)
In-Reply-To: <0F3C2194-AAA7-4F34-8EEA-9EA606198B2D@google.com>



On 12/11/2015 20:08, Matt Gingell wrote:
> +	bool req_int_win = !pic_in_kernel(vcpu->kvm) &&
>  		vcpu->run->request_interrupt_window;

Hey, this is the new form of dm_request_for_irq_injection I have
just written about, in the review to patch 3.

So it's probably best to swap these two.

>  	bool req_immediate_exit = false;
>  
> +	if (irqchip_split(vcpu->kvm))
> +		req_int_win = req_int_win && kvm_apic_accept_pic_intr(vcpu);

Overall this is

	bool req_int_win =
		vcpu->run->request_interrupt_window &&
		!pic_in_kernel(vcpu->kvm) &&
		(!lapic_in_kernel(vcpu) || kvm_apic_accept_pic_intr(vcpu))

writing it in this form is nice, because it's again very similar to
the tests you're using in patch 3.

Paolo

      reply	other threads:[~2015-11-13  8:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 19:08 [PATCH 2/3] KVM: x86: request interrupt window when IRQ chip is split Matt Gingell
2015-11-13  8:56 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5645A5A0.30701@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=gingell@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=srutherford@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.