From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxGni-00046T-4h for qemu-devel@nongnu.org; Fri, 13 Nov 2015 11:02:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxGnY-0001Vz-BI for qemu-devel@nongnu.org; Fri, 13 Nov 2015 11:02:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxGnY-0001Ve-3r for qemu-devel@nongnu.org; Fri, 13 Nov 2015 11:02:00 -0500 References: <1446551816-15768-1-git-send-email-zhang.zhanghailiang@huawei.com> <1446551816-15768-3-git-send-email-zhang.zhanghailiang@huawei.com> From: Eric Blake Message-ID: <56460971.3080800@redhat.com> Date: Fri, 13 Nov 2015 09:01:53 -0700 MIME-Version: 1.0 In-Reply-To: <1446551816-15768-3-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E8RPk0UQBbT38jGVoV72rMm0cdbmm2WPr" Subject: Re: [Qemu-devel] [PATCH COLO-Frame v10 02/38] migration: Introduce capability 'x-colo' to migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Markus Armbruster , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E8RPk0UQBbT38jGVoV72rMm0cdbmm2WPr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/03/2015 04:56 AM, zhanghailiang wrote: > We add helper function colo_supported() to indicate whether > colo is supported or not, with which we use to control whether or not > showing 'x-colo' string to users, they can use qmp command > 'query-migrate-capabilities' or hmp command 'info migrate_capabilities'= > to learn if colo is supported. >=20 > Cc: Juan Quintela > Cc: Amit Shah > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > --- > v10: > - Rename capability 'colo' to experimental 'x-colo' (Eric's suggestion)= =2E > - Rename migrate_enable_colo() to migrate_colo_enabled() (Eric's sugges= tion). > +++ b/qapi-schema.json > @@ -540,11 +540,15 @@ > # @auto-converge: If enabled, QEMU will automatically throttle down th= e guest > # to speed up convergence of RAM migration. (since 1.6) > # > +# @x-colo: If enabled, migration will never end, and the state of the = VM on the > +# primary side will be migrated continuously to the VM on secon= dary > +# side. (since 2.5) I think this has missed 2.5, so you'll need to tweak it to say 2.6. With that fixed, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --E8RPk0UQBbT38jGVoV72rMm0cdbmm2WPr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWRglxAAoJEKeha0olJ0Nq7z0H/j+np+dESUxBimHtFx5Mx5wX 7Sf/QOVBjuptZhMO/4PqvdBMdwyr3oTRaZ8XZbromEyNGIRbV7bm8HMPuMWOBnH4 6oxB4uz/nXs9EkoUI+jOU2PQqDusqMRJAlvPr+Ce0SrcFmHB2CgcaMPZfQ791N/k KJ0m/ACiURgJX7qtkTrYvvbvrRRmnBfSusb2URlKhAPUm/9C7Sze/s6CH/JTi1XP 1NMPe/ptymTcZFlK7f0GflZLwl1mvbt0CB3gUaZZd+9EuGo0zDjK6SDfAM4pnsEj hS7rRuTcswc5MDB60NVt6Nbi5XNliOsaNAncu12TBeGKwly3CKxCbVs4HtBlepU= =iLlv -----END PGP SIGNATURE----- --E8RPk0UQBbT38jGVoV72rMm0cdbmm2WPr--