From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH 9/9] IB/iser: Convert to CQ abstraction Date: Sun, 15 Nov 2015 11:21:08 +0200 Message-ID: <56484E84.6040904@mellanox.com> References: <1447422410-20891-1-git-send-email-hch@lst.de> <1447422410-20891-10-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447422410-20891-10-git-send-email-hch-jcswGhMUV9g@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org, bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org, axboe-b10kYP2dOMg@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sagi Grimberg List-Id: linux-rdma@vger.kernel.org On 11/13/2015 3:46 PM, Christoph Hellwig wrote: > From: Sagi Grimberg Care to sparse some text here to assist a reviewer and future bisections?! I have asked multiple times to avoid empty change-logs for patches in this driver. > > Signed-off-by: Sagi Grimberg > Signed-off-by: Christoph Hellwig > --- > drivers/infiniband/ulp/iser/iscsi_iser.h | 68 ++++--- > drivers/infiniband/ulp/iser/iser_initiator.c | 142 ++++++++++----- > drivers/infiniband/ulp/iser/iser_memory.c | 21 ++- > drivers/infiniband/ulp/iser/iser_verbs.c | 258 ++++++--------------------- > 4 files changed, 209 insertions(+), 280 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752569AbbKOJV0 (ORCPT ); Sun, 15 Nov 2015 04:21:26 -0500 Received: from mail-db3on0071.outbound.protection.outlook.com ([157.55.234.71]:30896 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752380AbbKOJVU (ORCPT ); Sun, 15 Nov 2015 04:21:20 -0500 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Subject: Re: [PATCH 9/9] IB/iser: Convert to CQ abstraction To: Christoph Hellwig , References: <1447422410-20891-1-git-send-email-hch@lst.de> <1447422410-20891-10-git-send-email-hch@lst.de> CC: , , , , , Sagi Grimberg From: Or Gerlitz Message-ID: <56484E84.6040904@mellanox.com> Date: Sun, 15 Nov 2015 11:21:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447422410-20891-10-git-send-email-hch@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.223.3.56] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD021;1:+iS5gruFkDPcEYXxSi/hApGWx9iYXy0XvPXp/9F4DN8JiB3nYUu56wZjBZJVt5U+OiGLemaxoPd2eb3A/ZXP+gMngZvUd5ICOj3BP8N1nGxaAL/64idV4M5ifYsWeAtVO/ELFBE8NK4G4H0EHlCTGzdA3A4NV5LtRjQafeBTZgCNXFGW6vSdQAgNqGB1XwDRs3dmvmdg6UKme0sb8joMUJlQDqQHkQQ2XFvCQdeGGASqXUlLZJAEoYWCaXZFtoTZrTO+tA+6y32+kKrhmdVKFHd2QhVkui2W1zfh4wEcmoVWIgXoqKbg6NRZX6bXO6yvlJVJbrOQbcB4bMf/Jv6G4R8YrTbN7hsZZEcY4fJ5JVmePYUvY8drxjehjS/WeVYmwmGzj9qQ2uqO2NIqINBJvA== X-Forefront-Antispam-Report: CIP:193.47.165.134;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(377454003)(479174004)(24454002)(50466002)(2950100001)(92566002)(4001350100001)(5007970100001)(11100500001)(5004730100002)(77096005)(99136001)(76176999)(54356999)(50986999)(87266999)(586003)(83506001)(65816999)(87936001)(107886002)(97736004)(5001770100001)(189998001)(33656002)(4001430100002)(6806005)(5008740100001)(64126003)(230700001)(106466001)(23746002)(59896002)(65806001)(86362001)(19580395003)(19580405001)(80316001)(65956001)(47776003)(36756003)(7059030)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR05MB357;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:ErrorRetry;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB357;2:xJ1iP/VV4EnQ2V0JfT7VgLuoedvyrOEiAL5eyFDfMb8b1KoM4wlEv26Cmf4j3hdSF+JW9gINrzPKlYIQ8PnprNn+R1JKtukpSTjqOLNS1mkfsHGeZSPWR4Dbf/G81gL5Quikeb930m3c8uonZW5ex0iQgeTFq6ICYVri8wudqFk=;3:6t+hVcmLrb9SHUFGOYfEDLyiHrRSnO/MhjIAzIBa/SNzMFBRuGyx3ztTuembX/lTYK/7RyIxkh9wg1+PBkFQp64xIS0M/bTOV54nvr7g1oYgY5P+yonBUgHDcwlLNTMsFPByU2nl894oZVx3WDTbOHBYMebajND+xs5jpcw/x+467y+tpslHopm3kq37x63fav83eVFzK3yBQQ7A0N7yemPulpZz0EId8hbWKStooZHFjTHrAIf5SPO32+DjIWy6BQ0VYQCpRTJKEnor5OzTxQ==;25:tXUuMMDN0wovYzyEmYnGhO5jXkPZjVyTrzgFPhkn9G8w/i0QNQXbiOt/DTCSdNfglcB4P9In6qXuGwwce919cyaPsJ9jEFnYbvzY7WUe8lc8TAfkkuR5m3PT0YQ9vaAlSuWVNRdiI4Gd887aBQqBVNwkrrDDlHMYxQAZD5VEpJAcIYiFCf0Z1YZ8/6nzUp2EaW+lh+LBr0LQUXAgkz+pUUQm4ek+5SyfOcvWfl3lg4XYXCSO+nP25MaxSOon8X6D X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:AMSPR05MB357; X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB357;20:n1bPwX8phbKKHjT4tVKLepg2vYTxO3bRQdGRczwu3XonGSxha6xTMOTjFE8xy5nrtHCbH9kre9/0y1hCGluQZHQbG5jFCzfHZC33epHYz6LWSLthNh3Aau7mju71G+GxeugDNGLVqMlTvzjqmXvAi5MZ6VimrjLAnrZNo5dIMg3XIWe8cb89TIO2MNUG8eEYoiGuqeyEsuYr8KERYzkcXW4+WtKrz4Y0nvujNrToqcWrQ0xl0KnjwsFO/UC8iUXSbSZllyY5E5NAfbaysKCnJqw/5dKnECQeegDnXX4rKsdeankkgb4bYY5ZftQKqkDoiTGCEAkHOeY47lrdt6sLy9NNXxOlU3ked7GOiLuI51UUknfYIZxF1A405eFJJsVLVk+q1s/Tky27y38DgQiYgiDLCu+yB/13tq2PUxsqUXSUAyLPDyGXJT5bI9YNHhwWItIeLB9C4b+ucGCWvPsHDjQjmF1ZHSTun0EVre4jvR4DRGxRzwmVdRmiT9dcV5cs;4:0BEvPR3QT1GwTyFLu9/oIricjkcZ0RXTa5SgV0mko0EF5KdA1wSIHzYLdrFKfzA0v25uYh3TWHqErQv/NmAI/IyX6Pe9Bi4JVgPR4RFZWzMNWMOjVZgHEBaKYFMqCLogt+TwyKCnQNvUgzybS9UyB0F0synDVR9KK8qzXB6cji7Jeh9cCLoSRmccaX9X4llvhiq05KgVUrzppR+iKnvNMornr2x8tT5N1Qx3wQaKN4xf3V68Sx3TUC8lvnFgZCqJ4xt0lU7MVHVYxmphX9pWAxiCpqaGMJawCp8V8sFmG7h7eFUEKaZJfquWW6c3hwBHAf3Cn6DoCzPAbmy+0S0i0t8Uxq1LcsAvkjRgNV1imtS1w2pqxTUZVlfH66N6cDvz X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(34787635062028); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046);SRVR:AMSPR05MB357;BCL:0;PCL:0;RULEID:;SRVR:AMSPR05MB357; X-Forefront-PRVS: 0761DE1EDD X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AMSPR05MB357;23:6YPvQ0furFaADn+d0y18ZPht+4V0ACRzY+nHiy?= =?Windows-1252?Q?yIwih/107g1NG/CFOCKopgtmctNFogeEIu928e5qoWbU2ugw08CqLp0M?= =?Windows-1252?Q?ZAiNSmYRdePOUAksVF7CmI/r3GV3ROyL7kVdxxwWDq7+vdkn/ZRuyh3Q?= =?Windows-1252?Q?gBX/3f1yU4Gj3+ma9txCoYmYWTN5MJYhmaQkWLGMayObehzT6QN0Qy42?= =?Windows-1252?Q?VVjNOKqCPaUrex7twVYjqYYZFrfTcmiUgAIVa5/98JDGINOwHG7vzsaY?= =?Windows-1252?Q?ZGKd13DDyjbKnOy7f0Hz1Q63COQUfCATorojN30RA1Ug/obUgoIG4mby?= =?Windows-1252?Q?DX9hgCMKEgyCv80de4SGd7NWmUkfj/FiLHRT6mRbRXzgPWbKAsPAa4lo?= =?Windows-1252?Q?tgxgZXBEd4Mf18Z9zt7agv5h7KcY16e1x6usdpy4t7co8SpfeXivCpub?= =?Windows-1252?Q?y20Y+BT7PbxCmp9CX4+LXZx8v/0ENxXsAkPZg5na5K7Y3gvFXEHsKc7T?= =?Windows-1252?Q?2IkmvhdXljeFWZhI/LUUvXwPWKWftwkRHpZchl0crbDupaZmuGneYAeP?= =?Windows-1252?Q?ZBfW8wSU6m/IMGrW1TL0ISL9t4BXFb+yz3DCGd1sBMzXfUvjd8g4bNVR?= =?Windows-1252?Q?4ssqzZ54smYoZAJqDT3jAnPd7V2skUiR6RwjG0gZmUo8EpbUZ/SFLWH3?= =?Windows-1252?Q?xgGNGjKRkOooB+lrW/7Dn1LbmS/oBoOZ3KI/xuAztHo+HUi33AKXaba7?= =?Windows-1252?Q?Q3zEUfpvZsoXffTD9BRCz8yNHJ33dYogtA6pXOgouo19nPtN5MNK3kRk?= =?Windows-1252?Q?k0sVDk4+jYDn9XgdismCDv3rnIoVLA4IO0KxwnMBDYWZ5e9spALwwWjv?= =?Windows-1252?Q?qRQsKufsCgGVaAEx+anY1iV5Yx0yTuJqbxbHokAIXVlV1oEE+e4WzySn?= =?Windows-1252?Q?RMkmedNkWY6tUHmg8JuFzPlJlJDlq+PctoYOXJqrqn7LOCwce78B1coF?= =?Windows-1252?Q?UHYMXCQEUxlA/BgfmgbAVRpwsjd9YlbdW/1o5WNDfvkTPNL2SKSGsCIo?= =?Windows-1252?Q?ytOU6T4mdQqgJT/jssBob5Kd7G3rfjfoyZ4nmOFzhp0zBB33RZViNZBz?= =?Windows-1252?Q?ydUr0VY2+i3xc5yFz7TX7ZhjkMB+6PMR0p+hhLFnOnUSnXw/yCArHmrL?= =?Windows-1252?Q?kmUEqX3KoR07EH0R4fRUKl22lIIyUWi/+BE7kyt0zhE/MQEn/OfuTFkB?= =?Windows-1252?Q?i49WZ/96emMoJ2TRUnYH5JM/iCzTk2VJe959I5R6EiRM8O9LcH9hM5en?= =?Windows-1252?Q?b6JZ2IdM0G1wxtUN7vvcs8Cy98rD/MLxg3ZmOWuG9r3x/BBphj2uE/SR?= =?Windows-1252?Q?IzJ6nIkdmR?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB357;5:QNLMK9TCKhPy+PBuqf0yG2hvjs0DMSCD7VkXfEI5bFkpxJdBig/UDg0hjJl93HdKx3MCuqiBL/35MXD1TSzth+UpTERTdIAX1TZo/agsymfQ4bcUNK67TgcY9vx9XTfsst20Q/laSkgHTWQv6hX2lg==;24:kNzdgAiAB0Mre+8AzTFF8RTwj/v0OQlQrwoGg//+etTDs4MrQRET0c6EqeY8QdRE7jghJmeiW7tgk6z4zk4jC43H6t9dUEBfP3rxH5jTMy0=;20:VMF4A9cuIMwgT2y2JPXkkZldVBeTSWaFNYxm+UmJ4dkaNYc2+XyAg5rxq9OGLrsGQHHe+u1GT3zeWDmY4tiwdg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2015 09:21:12.7969 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR05MB357 X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB0595;2:HAapQJL5ApSdMF+cxqXzCktxiZF7qTL5wTDuuz6iLGRS8mZdLIiYCtSMgW4iKSau4JkiEzODpqZKbWD97NH1rKMfKX0C1k0Xlm9znRBi8AinS/tKz1p3mEa7GE1jRNmURXz/sVb88M6YPCY913rlWR37YDoGpZTyF/6KBO70WzQ=;23:t8ETaa71oU4j41gvK6wjk8D7WJhWz/mth5tRvxvykk/s0r666RzNeWUGVa72DlUkyhJeejy1e72aFlTSTmo8QUJbUP14SabGkHR10LIwFEUeO2mGhrdmROHsv9x/uPKN3z8yM3OjqhNOVU0r3XhEoGZePv1MPBqjO6VlPXWwvjzrrbFvJh8kTyfxPOtvP16d X-OriginatorOrg: Mellanox.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/2015 3:46 PM, Christoph Hellwig wrote: > From: Sagi Grimberg Care to sparse some text here to assist a reviewer and future bisections?! I have asked multiple times to avoid empty change-logs for patches in this driver. > > Signed-off-by: Sagi Grimberg > Signed-off-by: Christoph Hellwig > --- > drivers/infiniband/ulp/iser/iscsi_iser.h | 68 ++++--- > drivers/infiniband/ulp/iser/iser_initiator.c | 142 ++++++++++----- > drivers/infiniband/ulp/iser/iser_memory.c | 21 ++- > drivers/infiniband/ulp/iser/iser_verbs.c | 258 ++++++--------------------- > 4 files changed, 209 insertions(+), 280 deletions(-)