All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
	amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/amd/pm: Don't output SMU version for smu13 every time
Date: Fri, 30 Jul 2021 10:31:09 +0530	[thread overview]
Message-ID: <5648c894-5caa-ccb0-fec4-6b0d7acb74b4@amd.com> (raw)
In-Reply-To: <20210730024050.248-1-mario.limonciello@amd.com>



On 7/30/2021 8:10 AM, Mario Limonciello wrote:
> This adjusts SMU13 to match SMU11 and SMU12 behaviors in not showing
> this message all the time.  It will still be accessible via
> /sys/kernel/debug/dri/0/amdgpu_firmware_info
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> index a421ba85bd6d..9c99c51740a1 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> @@ -219,9 +219,6 @@ int smu_v13_0_check_fw_version(struct smu_context *smu)
>   		break;
>   	}
>   
> -	dev_info(smu->adev->dev, "smu fw reported version = 0x%08x (%d.%d.%d)\n",
> -			 smu_version, smu_major, smu_minor, smu_debug);
> -

Suggest to keep this at debug level. There are cases like a failed 
driver load (debugfs files are not created) where we need to check this 
information.

Thanks,
Lijo

>   	/*
>   	 * 1. if_version mismatch is not critical as our fw is designed
>   	 * to be backward compatible.
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply	other threads:[~2021-07-30  5:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30  2:40 [PATCH 1/3] drm/amd/pm: Don't output SMU version for smu13 every time Mario Limonciello
2021-07-30  2:40 ` [PATCH 2/3] drm/amdgpu: Convert SMU version to decimal in debugfs Mario Limonciello
2021-07-30  5:08   ` Lazar, Lijo
2021-07-30  2:40 ` [PATCH 3/3] drm/amd/pm: Downgrade SMU mismatch information messages Mario Limonciello
2021-07-30  4:54   ` Lazar, Lijo
2021-07-30  5:01 ` Lazar, Lijo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5648c894-5caa-ccb0-fec4-6b0d7acb74b4@amd.com \
    --to=lijo.lazar@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=mario.limonciello@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.