From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768AbbKOXyz (ORCPT ); Sun, 15 Nov 2015 18:54:55 -0500 Received: from mxf4.bahnhof.se ([213.80.101.28]:64383 "EHLO mxf4.bahnhof.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752660AbbKOXyb (ORCPT ); Sun, 15 Nov 2015 18:54:31 -0500 X-Spam-Score: 0 Subject: Re: [PATCH -next] serial: etraxfs-uart: Fix crash To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= References: <1446431576-4385-1-git-send-email-linux@roeck-us.net> <20151102073755.GN4931@pengutronix.de> <5637D1F5.2090608@flawful.org> <20151102212933.GB4931@pengutronix.de> Cc: Guenter Roeck , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org From: Niklas Cassel Message-ID: <56491B2F.30300@flawful.org> Date: Mon, 16 Nov 2015 00:54:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151102212933.GB4931@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I think that Guenter's patch should be merged asap. Right now the bug it fixes stops us from boot testing in qemu. For the broken mctrl irq handling part, when Uwe has converted mxs-auart to use the generic irq init, I can do the same for etraxfs + make sure that it gets tested properly on real hardware. On 11/02/2015 10:29 PM, Uwe Kleine-König wrote: > Helo Niklas, > > On Mon, Nov 02, 2015 at 10:13:25PM +0100, Niklas Cassel wrote: >> On 11/02/2015 08:37 AM, Uwe Kleine-König wrote: >>>> The function call in the etraxfs-uart driver was not renamed, >>>> possibly due to interference with commit 7b9c5162c182 ("serial: >>>> etraxfs-uart: use mctrl_gpio helpers for handling modem signals"). >>> Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handling >>> is missing. >> The only drivers including serial_mctrl_gpio.h is atmel_serial.c, >> clps711x.c, mxs-auart.c and etraxfs-uart.c >> >> etraxfs commit >> 7b9c5162c182 ("serial: etraxfs-uart: use mctrl_gpio helpers for handling modem signals") >> is heavily influenced by >> 62b0a1b3e759 ("serial: clps711x: Use mctrl_gpio helpers for handling modem signals") >> >> a driver which also appears to lack mctrl irq setup/handling. >> >> >> Uwe, are you going to convert all serial drivers that includes serial_mctrl_gpio.h to >> use the new mctrl_gpio_init? (which also sets up irqs) > That is the plan. For drivers like mxs-auart (that do irq handling) this > is just simplification. When the irq handling is missing converting to > the new mctrl_gpio_init might introduce regressions because it does > request_irq which might fail. > >> Since mctrl gpios are optional in the device tree, I guess mctrl_gpio_init handles if >> they are missing. So even if etraxfs-uart.c currently lacks mctrl irq setup/handling, >> if we migrate it to use the new mctrl_gpio_init, we will get this automatically? > Right, if there are no gpios specified (new and old) mctrl_gpio is a > nop. > > Best regards > Uwe >