From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyFGl-0000Xj-0X for qemu-devel@nongnu.org; Mon, 16 Nov 2015 03:36:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyFGh-00088e-O5 for qemu-devel@nongnu.org; Mon, 16 Nov 2015 03:36:10 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:54820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyFGg-00088G-Sz for qemu-devel@nongnu.org; Mon, 16 Nov 2015 03:36:07 -0500 References: <1446551816-15768-1-git-send-email-zhang.zhanghailiang@huawei.com> <1446551816-15768-3-git-send-email-zhang.zhanghailiang@huawei.com> <56460971.3080800@redhat.com> From: zhanghailiang Message-ID: <56499555.5060909@huawei.com> Date: Mon, 16 Nov 2015 16:35:33 +0800 MIME-Version: 1.0 In-Reply-To: <56460971.3080800@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH COLO-Frame v10 02/38] migration: Introduce capability 'x-colo' to migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Markus Armbruster , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com On 2015/11/14 0:01, Eric Blake wrote: > On 11/03/2015 04:56 AM, zhanghailiang wrote: >> We add helper function colo_supported() to indicate whether >> colo is supported or not, with which we use to control whether or not >> showing 'x-colo' string to users, they can use qmp command >> 'query-migrate-capabilities' or hmp command 'info migrate_capabilities' >> to learn if colo is supported. >> >> Cc: Juan Quintela >> Cc: Amit Shah >> Cc: Eric Blake >> Cc: Markus Armbruster >> Signed-off-by: zhanghailiang >> Signed-off-by: Li Zhijian >> Signed-off-by: Gonglei >> --- >> v10: >> - Rename capability 'colo' to experimental 'x-colo' (Eric's suggestion). >> - Rename migrate_enable_colo() to migrate_colo_enabled() (Eric's suggestion). > >> +++ b/qapi-schema.json >> @@ -540,11 +540,15 @@ >> # @auto-converge: If enabled, QEMU will automatically throttle down the guest >> # to speed up convergence of RAM migration. (since 1.6) >> # >> +# @x-colo: If enabled, migration will never end, and the state of the VM on the >> +# primary side will be migrated continuously to the VM on secondary >> +# side. (since 2.5) > > I think this has missed 2.5, so you'll need to tweak it to say 2.6. > Yes, will update it in next version. > With that fixed, > Reviewed-by: Eric Blake > Thanks.