From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: "Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Sagi Grimberg <sagig@mellanox.com>
Subject: Re: [PATCH 1/2] iscsi-target: Fix rx_login_comp hang after login failure
Date: Mon, 16 Nov 2015 13:27:56 +0200 [thread overview]
Message-ID: <5649BDBC.5080601@dev.mellanox.co.il> (raw)
In-Reply-To: <1447546903-15305-2-git-send-email-nab@daterainc.com>
On 15/11/2015 02:21, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> This patch addresses a case where iscsi_target_do_tx_login_io()
> fails sending the last login response PDU, after the RX/TX
> threads have already been started.
>
> The case centers around iscsi_target_rx_thread() not invoking
> allow_signal(SIGINT) before the send_sig(SIGINT, ...) occurs
> from the failure path, resulting in RX thread hanging
> indefinately on iscsi_conn->rx_login_comp.
>
> Note this bug is a regression introduced by:
>
> commit e54198657b65625085834847ab6271087323ffea
> Author: Nicholas Bellinger <nab@linux-iscsi.org>
> Date: Wed Jul 22 23:14:19 2015 -0700
>
> iscsi-target: Fix iscsit_start_kthreads failure OOPs
>
> To address this bug, complete ->rx_login_complete for good
> measure in the failure path, and immediately return from
> RX thread context if connection state did not actually reach
> full feature phase (TARG_CONN_STATE_LOGGED_IN).
Hey Nic,
Will it make better sense to start the rx/tx threads after
the login was completed (i.e. the conn is in state
TARG_CONN_STATE_LOGGED_IN) instead?
Sagi.
next prev parent reply other threads:[~2015-11-16 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 0:21 [PATCH 0/2] target: kthread login failure hung task + CAW use-after-free Nicholas A. Bellinger
2015-11-15 0:21 ` [PATCH 1/2] iscsi-target: Fix rx_login_comp hang after login failure Nicholas A. Bellinger
2015-11-16 11:27 ` Sagi Grimberg [this message]
2015-11-15 0:21 ` [PATCH 2/2] target: Fix race for SCF_COMPARE_AND_WRITE_POST checking Nicholas A. Bellinger
2015-12-18 13:05 ` [PATCH 0/2] target: kthread login failure hung task + CAW use-after-free Martin Svec
2015-12-21 7:19 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5649BDBC.5080601@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.