From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbbKPLjL (ORCPT ); Mon, 16 Nov 2015 06:39:11 -0500 Received: from demumfd002.nsn-inter.net ([93.183.12.31]:47098 "EHLO demumfd002.nsn-inter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbbKPLjH (ORCPT ); Mon, 16 Nov 2015 06:39:07 -0500 Subject: Re: [PATCH] pstore: add support for 64 Bit address space To: EXT Kees Cook References: <27017B294887C64C94ACAE870D1C65952A977B13@DEMUMBX013.nsn-intra.net> Cc: "anton@enomsg.org" , "ccross@android.com" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" From: Wladislav Wiebe Message-ID: <5649C04C.8000406@nokia.com> Date: Mon, 16 Nov 2015 12:38:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-size: 2011 X-purgate-ID: 151667::1447673933-000015C7-B5BACC20/0/0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 14.11.2015 um 00:46 schrieb EXT Kees Cook: > On Fri, Nov 13, 2015 at 4:10 AM, Wiebe, Wladislav (Nokia - DE/Ulm) > wrote: >> Some architectures has there reserved RAM in 64 Bit address space. >> Therefore converting mem_address module parameter to ullong. >> >> Signed-off-by: Wladislav Wiebe > > If this works correctly, I have no objection. :) I can confirm, it works fine :-) Thanks! - Wladislav Wiebe > > Acked-by: Kees Cook > > Thanks! > > -Kees > >> --- >> fs/pstore/ram.c | 4 ++-- >> include/linux/pstore_ram.h | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c >> index 319c3a6..bd9812e 100644 >> --- a/fs/pstore/ram.c >> +++ b/fs/pstore/ram.c >> @@ -55,8 +55,8 @@ static ulong ramoops_pmsg_size = MIN_MEM_SIZE; >> module_param_named(pmsg_size, ramoops_pmsg_size, ulong, 0400); >> MODULE_PARM_DESC(pmsg_size, "size of user space message log"); >> >> -static ulong mem_address; >> -module_param(mem_address, ulong, 0400); >> +static unsigned long long mem_address; >> +module_param(mem_address, ullong, 0400); >> MODULE_PARM_DESC(mem_address, >> "start of reserved RAM used to store oops/panic logs"); >> >> diff --git a/include/linux/pstore_ram.h b/include/linux/pstore_ram.h >> index 9c9d6c1..4660aaa 100644 >> --- a/include/linux/pstore_ram.h >> +++ b/include/linux/pstore_ram.h >> @@ -76,7 +76,7 @@ ssize_t persistent_ram_ecc_string(struct persistent_ram_zone *prz, >> >> struct ramoops_platform_data { >> unsigned long mem_size; >> - unsigned long mem_address; >> + phys_addr_t mem_address; >> unsigned int mem_type; >> unsigned long record_size; >> unsigned long console_size; >> -- >> 1.7.1 >> >> Regards, >> Wladislav Wiebe >> >> > > > -- Regards, Wladislav Wiebe