From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyJcS-0007kr-9s for qemu-devel@nongnu.org; Mon, 16 Nov 2015 08:14:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyJcN-00059k-MJ for qemu-devel@nongnu.org; Mon, 16 Nov 2015 08:14:52 -0500 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:38540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyJcN-00059c-DK for qemu-devel@nongnu.org; Mon, 16 Nov 2015 08:14:47 -0500 Message-ID: <5649D6BF.20204@weilnetz.de> Date: Mon, 16 Nov 2015 14:14:39 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1447165546-27784-1-git-send-email-quintela@redhat.com> <1447165546-27784-26-git-send-email-quintela@redhat.com> <5647877D.6050201@weilnetz.de> <20151116100734.GB2417@work-vm> In-Reply-To: <20151116100734.GB2417@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 25/57] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: amit.shah@redhat.com, Paolo Bonzini , qemu-devel@nongnu.org, Juan Quintela Am 16.11.2015 um 11:07 schrieb Dr. David Alan Gilbert: > * Stefan Weil (sw@weilnetz.de) wrote: >> Am 10.11.2015 um 15:25 schrieb Juan Quintela: >>> From: "Dr. David Alan Gilbert" >>> >>> The state of the postcopy process is managed via a series of messages= ; >>> * Add wrappers and handlers for sending/receiving these messages >>> * Add state variable that track the current state of postcopy >>> >>> Signed-off-by: Dr. David Alan Gilbert >>> Reviewed-by: Amit Shah >>> Reviewed-by: Juan Quintela >>> Signed-off-by: Juan Quintela >>> --- >>> include/migration/migration.h | 27 +++++ >>> include/sysemu/sysemu.h | 19 ++++ >>> migration/migration.c | 20 ++++ >>> migration/savevm.c | 254 ++++++++++++++++++++++++++++++++= ++++++++++ >>> trace-events | 10 ++ >>> 5 files changed, 330 insertions(+) >>> >> [...] >>> diff --git a/migration/savevm.c b/migration/savevm.c >> [...] >>> + if (remote_hps !=3D getpagesize()) { >>> + /* >>> + * Some combinations of mismatch are probably possible but i= t gets >>> + * a bit more complicated. In particular we need to place w= hole >>> + * host pages on the dest at once, and we need to ensure tha= t we >>> + * handle dirtying to make sure we never end up sending part= of >>> + * a hostpage on it's own. >>> + */ >>> + error_report("Postcopy needs matching host page sizes (s=3D%= d d=3D%d)", >>> + (int)remote_hps, getpagesize()); >> >> This statement introduces a new warning when compiling for >> Windows where getpagesize() returns a size_t. I'll send a patch >> to change that definition to return an int value. >=20 > Interesting; which compiler are you using; I don't think any of us test= ing with > ming hit that. I use Debian GNU Linux jessie with package gcc-mingw-w64-x86-64. CC i386-softmmu/migration/savevm.o migration/savevm.c: In function =91loadvm_postcopy_handle_advise=92: migration/savevm.c:1284:22: warning: format =91%d=92 expects argument of type =91int=92, but argument 3 has type =91size_t=92 [-Wformat=3D] (int)remote_hps, getpagesize()); ^ $ x86_64-w64-mingw32-gcc --version x86_64-w64-mingw32-gcc (GCC) 4.9.1 Copyright (C) 2014 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is N= O warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOS= E.