From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59139)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZyKRe-0003re-OK
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 09:07:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZyKRa-0002zJ-PI
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 09:07:46 -0500
References: <1447682723-3977-1-git-send-email-peter.maydell@linaro.org>
	<1447682723-3977-5-git-send-email-peter.maydell@linaro.org>
From: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Message-ID: <5649E323.8050407@suse.de>
Date: Mon, 16 Nov 2015 15:07:31 +0100
MIME-Version: 1.0
In-Reply-To: <1447682723-3977-5-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 04/19] include/qom/cpu.h: Add new
 get_phys_page_attrs_debug method
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, qemu-arm@nongnu.org, patches@linaro.org

Am 16.11.2015 um 15:05 schrieb Peter Maydell:
> Add a new optional method get_phys_page_attrs_debug to CPUClass.
> This is like the existing get_phys_page_debug, but also returns
> the memory transaction attributes to use for the access.
> This will be necessary for CPUs which have multiple address
> spaces and use the attributes to select the correct address
> space.
>=20
> We provide a wrapper function cpu_get_phys_page_attrs_debug()
> which falls back to the existing get_phys_page_debug(), so we
> don't need to change every target CPU.
>=20
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  include/qom/cpu.h | 36 ++++++++++++++++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)

Please use "qom:" and () by convention, otherwise looks fine.

Regards,
Andreas

--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC=
rnberg)