From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751855AbbKQFb5 (ORCPT ); Tue, 17 Nov 2015 00:31:57 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:58556 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbbKQFbz (ORCPT ); Tue, 17 Nov 2015 00:31:55 -0500 Subject: Re: [PATCH v5 00/11] exynos-ufs: add support for Exynos To: Alim Akhtar , Alim Akhtar References: <1447046787-480-1-git-send-email-alim.akhtar@samsung.com> CC: , "linux-kernel@vger.kernel.org" , "James E.J. Bottomley" , vinayak holikatti , Vivek Gautam , Seungwon Jeon , "devicetree@vger.kernel.org" From: Kishon Vijay Abraham I Message-ID: <564ABB64.3080001@ti.com> Date: Tue, 17 Nov 2015 11:00:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alim, On Monday 16 November 2015 06:31 AM, Alim Akhtar wrote: > Hi Kishon, > > Any more concern on the PHY part of this series? Sorry for the late reply. Yes, I still have concerns. I'll comment on your patch. Thanks Kishon > > Thanks! > > On Mon, Nov 9, 2015 at 10:56 AM, Alim Akhtar wrote: >> This patch-set introduces UFS (Universal Flash Storage) host support >> for Samsung Exynos SoC. Mostly, it consists of UFS PHY and host specific driver. >> And it also contains some quirks handling for Exynos. >> >> NOTE: ** This series has a dependency on [4]. ** >> >> -Changes since v4: >> * Removed platform specific PHY ops as suggested by Kishon >> * Rebased on the top of Yaniv Gardi's work [4] >> * make use of newly introduce ufshcd_{get,set}_variant >> * other small changes and improvements. >> * rebased on the top of linux next-20151109 >> >> -Changes since v3: >> * Fixed compilation warrings as reported by "Kbuild Test Robot"[5]. >> * Restructure the driver to make it as a platform driver, rebased on top of [4]. >> * Addressed review comments from Arnd Bergmann[5]. >> * Other misc changes and improvements. >> >> -Changes since v2: >> * Addressed review comments from Kishon[1] and Rob Herring [2] >> * Splited ufs dt binding documetation from ufs driver patch >> >> -Changes since v1: >> * Addressed review comments from Alexey[3] and various review comments from Amit. >> * Updated email id of Seungwon as his samsung id is void now. >> * Added ufs platform data >> >> [1]-> https://lkml.org/lkml/2015/9/18/29 >> [2]-> https://lkml.org/lkml/2015/9/21/668 >> [3]-> https://lkml.org/lkml/2015/8/23/124 >> [4]-> https://lkml.org/lkml/2015/10/28/271 >> [5]-> https://lkml.org/lkml/2015/10/1/402 >> >> This patch set is tested on exynos7-espresso board. >> >> >> Alim Akhtar (1): >> Documentation: samsung-phy: Add dt bindings for UFS >> >> Seungwon Jeon (10): >> phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC >> scsi: ufs: add quirk to contain unconformable utrd field >> scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr >> scsi: ufs: add quirk not to allow reset of interrupt aggregation >> scsi: ufs: add quirk to enable host controller without hce >> scsi: ufs: add specific callback for nexus type >> scsi: ufs: add add specific callback for hibern8 >> scsi: ufs: make ufshcd_config_pwr_mode of non-static func >> Documentation: devicetree: ufs: Add DT bindings for exynos UFS host >> controller >> scsi: ufs-exynos: add UFS host support for Exynos SoCs >> >> .../devicetree/bindings/phy/samsung-phy.txt | 22 + >> .../devicetree/bindings/ufs/ufs-exynos.txt | 104 ++ >> drivers/phy/Kconfig | 7 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-exynos-ufs.c | 241 ++++ >> drivers/phy/phy-exynos-ufs.h | 85 ++ >> drivers/phy/phy-exynos7-ufs.h | 89 ++ >> drivers/scsi/ufs/Kconfig | 12 + >> drivers/scsi/ufs/Makefile | 1 + >> drivers/scsi/ufs/ufs-exynos-hw.c | 131 ++ >> drivers/scsi/ufs/ufs-exynos-hw.h | 43 + >> drivers/scsi/ufs/ufs-exynos.c | 1304 ++++++++++++++++++++ >> drivers/scsi/ufs/ufs-exynos.h | 247 ++++ >> drivers/scsi/ufs/ufshcd.c | 168 ++- >> drivers/scsi/ufs/ufshcd.h | 54 + >> drivers/scsi/ufs/ufshci.h | 26 +- >> drivers/scsi/ufs/unipro.h | 47 + >> include/linux/phy/phy-exynos-ufs.h | 85 ++ >> 18 files changed, 2647 insertions(+), 20 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/ufs/ufs-exynos.txt >> create mode 100644 drivers/phy/phy-exynos-ufs.c >> create mode 100644 drivers/phy/phy-exynos-ufs.h >> create mode 100644 drivers/phy/phy-exynos7-ufs.h >> create mode 100644 drivers/scsi/ufs/ufs-exynos-hw.c >> create mode 100644 drivers/scsi/ufs/ufs-exynos-hw.h >> create mode 100644 drivers/scsi/ufs/ufs-exynos.c >> create mode 100644 drivers/scsi/ufs/ufs-exynos.h >> create mode 100644 include/linux/phy/phy-exynos-ufs.h >> >> -- >> 1.7.10.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v5 00/11] exynos-ufs: add support for Exynos Date: Tue, 17 Nov 2015 11:00:12 +0530 Message-ID: <564ABB64.3080001@ti.com> References: <1447046787-480-1-git-send-email-alim.akhtar@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Alim Akhtar , Alim Akhtar Cc: linux-scsi@vger.kernel.org, "linux-kernel@vger.kernel.org" , "James E.J. Bottomley" , vinayak holikatti , Vivek Gautam , Seungwon Jeon , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hi Alim, On Monday 16 November 2015 06:31 AM, Alim Akhtar wrote: > Hi Kishon, > > Any more concern on the PHY part of this series? Sorry for the late reply. Yes, I still have concerns. I'll comment on your patch. Thanks Kishon > > Thanks! > > On Mon, Nov 9, 2015 at 10:56 AM, Alim Akhtar wrote: >> This patch-set introduces UFS (Universal Flash Storage) host support >> for Samsung Exynos SoC. Mostly, it consists of UFS PHY and host specific driver. >> And it also contains some quirks handling for Exynos. >> >> NOTE: ** This series has a dependency on [4]. ** >> >> -Changes since v4: >> * Removed platform specific PHY ops as suggested by Kishon >> * Rebased on the top of Yaniv Gardi's work [4] >> * make use of newly introduce ufshcd_{get,set}_variant >> * other small changes and improvements. >> * rebased on the top of linux next-20151109 >> >> -Changes since v3: >> * Fixed compilation warrings as reported by "Kbuild Test Robot"[5]. >> * Restructure the driver to make it as a platform driver, rebased on top of [4]. >> * Addressed review comments from Arnd Bergmann[5]. >> * Other misc changes and improvements. >> >> -Changes since v2: >> * Addressed review comments from Kishon[1] and Rob Herring [2] >> * Splited ufs dt binding documetation from ufs driver patch >> >> -Changes since v1: >> * Addressed review comments from Alexey[3] and various review comments from Amit. >> * Updated email id of Seungwon as his samsung id is void now. >> * Added ufs platform data >> >> [1]-> https://lkml.org/lkml/2015/9/18/29 >> [2]-> https://lkml.org/lkml/2015/9/21/668 >> [3]-> https://lkml.org/lkml/2015/8/23/124 >> [4]-> https://lkml.org/lkml/2015/10/28/271 >> [5]-> https://lkml.org/lkml/2015/10/1/402 >> >> This patch set is tested on exynos7-espresso board. >> >> >> Alim Akhtar (1): >> Documentation: samsung-phy: Add dt bindings for UFS >> >> Seungwon Jeon (10): >> phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC >> scsi: ufs: add quirk to contain unconformable utrd field >> scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr >> scsi: ufs: add quirk not to allow reset of interrupt aggregation >> scsi: ufs: add quirk to enable host controller without hce >> scsi: ufs: add specific callback for nexus type >> scsi: ufs: add add specific callback for hibern8 >> scsi: ufs: make ufshcd_config_pwr_mode of non-static func >> Documentation: devicetree: ufs: Add DT bindings for exynos UFS host >> controller >> scsi: ufs-exynos: add UFS host support for Exynos SoCs >> >> .../devicetree/bindings/phy/samsung-phy.txt | 22 + >> .../devicetree/bindings/ufs/ufs-exynos.txt | 104 ++ >> drivers/phy/Kconfig | 7 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-exynos-ufs.c | 241 ++++ >> drivers/phy/phy-exynos-ufs.h | 85 ++ >> drivers/phy/phy-exynos7-ufs.h | 89 ++ >> drivers/scsi/ufs/Kconfig | 12 + >> drivers/scsi/ufs/Makefile | 1 + >> drivers/scsi/ufs/ufs-exynos-hw.c | 131 ++ >> drivers/scsi/ufs/ufs-exynos-hw.h | 43 + >> drivers/scsi/ufs/ufs-exynos.c | 1304 ++++++++++++++++++++ >> drivers/scsi/ufs/ufs-exynos.h | 247 ++++ >> drivers/scsi/ufs/ufshcd.c | 168 ++- >> drivers/scsi/ufs/ufshcd.h | 54 + >> drivers/scsi/ufs/ufshci.h | 26 +- >> drivers/scsi/ufs/unipro.h | 47 + >> include/linux/phy/phy-exynos-ufs.h | 85 ++ >> 18 files changed, 2647 insertions(+), 20 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/ufs/ufs-exynos.txt >> create mode 100644 drivers/phy/phy-exynos-ufs.c >> create mode 100644 drivers/phy/phy-exynos-ufs.h >> create mode 100644 drivers/phy/phy-exynos7-ufs.h >> create mode 100644 drivers/scsi/ufs/ufs-exynos-hw.c >> create mode 100644 drivers/scsi/ufs/ufs-exynos-hw.h >> create mode 100644 drivers/scsi/ufs/ufs-exynos.c >> create mode 100644 drivers/scsi/ufs/ufs-exynos.h >> create mode 100644 include/linux/phy/phy-exynos-ufs.h >> >> -- >> 1.7.10.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > >