From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available Date: Tue, 17 Nov 2015 09:16:28 -0800 Message-ID: <564B60EC.3050106@sandisk.com> References: <1447422410-20891-1-git-send-email-hch@lst.de> <1447422410-20891-2-git-send-email-hch@lst.de> <564637BC.7080604@sandisk.com> <20151114070248.GB27738@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151114070248.GB27738@lst.de> Sender: linux-scsi-owner@vger.kernel.org To: Christoph Hellwig , Bart Van Assche Cc: linux-rdma@vger.kernel.org, sagig@dev.mellanox.co.il, axboe@fb.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On 11/13/2015 11:02 PM, Christoph Hellwig wrote: > On Fri, Nov 13, 2015 at 11:19:24AM -0800, Bart Van Assche wrote: >> On 11/13/2015 05:46 AM, Christoph Hellwig wrote: >>> The new name is irq_poll as iopoll is already taken. Better suggestions >>> welcome. >> >> Would it be possible to provide more background information about this ? >> Which other kernel subsystem is using the name iopoll ? > > Take a look at include/linux/iopoll.h - I can't reaplly make much sense > of it to be honest, but it's used in a quite a few places. How about renaming blk_iopoll into blk_poll ? That way the name still refers to the block layer. And although the current implementation performs polling from IRQ context future implementations maybe will allow polling from thread context. Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754072AbbKQRQh (ORCPT ); Tue, 17 Nov 2015 12:16:37 -0500 Received: from mail-bl2on0081.outbound.protection.outlook.com ([65.55.169.81]:31710 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751702AbbKQRQe (ORCPT ); Tue, 17 Nov 2015 12:16:34 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.172) smtp.mailfrom=sandisk.com; dev.mellanox.co.il; dkim=none (message not signed) header.d=none;dev.mellanox.co.il; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a68-f790b6d00000123b-bc-564b60ed8723 Subject: Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available To: Christoph Hellwig , Bart Van Assche References: <1447422410-20891-1-git-send-email-hch@lst.de> <1447422410-20891-2-git-send-email-hch@lst.de> <564637BC.7080604@sandisk.com> <20151114070248.GB27738@lst.de> CC: , , , , From: Bart Van Assche Message-ID: <564B60EC.3050106@sandisk.com> Date: Tue, 17 Nov 2015 09:16:28 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151114070248.GB27738@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42JZI8azSPdtgneYwbkXjBb/9xxjs1i5+iiT xeVdc9gsnh3qZbHovr6DzeL18adMDmwe02dsYvWY2PyO3WP3zQY2j8+b5AJYorhsUlJzMstS i/TtErgy5rZdZClYzFbx4sVplgbGFtYuRk4OCQETiZYpF9kgbDGJC/fWA9lcHEICJxglXq5a wALh7GCUmNV+ASjDAdbRfocbIr6JUWLr5qmMIHFhgWCJ90/qQQaJCARJLDl/ihGiZg2jxOw/ HewgDrNAD6NE7+qPYKvZBIwkvr2fyQJi8wpoSUxq3c8MYrMIqErc+baaEcQWFYiQmDihgRWi RlDi5MwnYPWcAjoSr96/YwFZzCxgL/FgaxlImFlAXmL72znMILskBG6ySjycfRpsjpCAusTJ JfOZJjCKzEIyahZC+ywk7QsYmVcxiuVm5hTnpqcWGBrqFSfmpWQWZ+sl5+duYgRHDVfGDsat k8wPMQpwMCrx8Aoc9woTYk0sK67MPcQowcGsJMLLaeUdJsSbklhZlVqUH19UmpNafIhRmoNF SZzXukUtTEggPbEkNTs1tSC1CCbLxMEp1cAoIGl18sq1rvrTqo3zQkseLMzvva/ateBwE9f2 iw3Bwns52xzX1qxh3Lv0kV7J8cNzFFh0VtpP5Wbibl4bm/EnLvkuT0Cxbda/UOfibnPuH42b 9zPmB6upFh5Yd96h58fqqddipzCy/nvxJuXdsQ9d/3Zf80z9/fZc96dFgt2KJmb7oktLZJYr sRRnJBpqMRcVJwIA6FAtq5YCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphluLIzCtJLcpLzFFi42Lh2siRovsmwTvM4Mx1Q4v/e46xWRz82cZo sXL1USaLy7vmsFk8O9TLYtF9fQebxevjT5kc2D2mz9jE6jGx+R27x+6bDWwe09acZ/L4vEku gDWKyyYlNSezLLVI3y6BK2Nu20WWgsVsFS9enGZpYGxh7WLk4JAQMJFov8PdxcgJZIpJXLi3 nq2LkYtDSGADo8SThU/ZQWqEBYIl3j+pB6kREQiSmHXtDjtEzRpGidl/OsAcZoEmRomJnQsY QarYBIwkvr2fyQJi8wpoSUxq3c8MYrMIqErc+bYarEZUIEJi4oQGVogaQYmTM5+A1XMK6Ei8 ev8OzGYWsJW4M3c3M4QtL7H97RzmCYz8s5C0zEJSNgtJ2QJG5lWMYrmZOcW56ZkFhkZ6xYl5 KZnF2XrJ+bmbGMHhzBm1g/H6RPNDjEwcnFINjGE6Nx48f24kFRUWqZx69/3+i7O2zH/522+a LXOI93IJ2Y8qfza+ivjkLrFqxs5l4qHmDz9I9v7OTF6gddpj+655kV7R954mNUYcNKg4Llvj 8OOG/8bLuzX6FXZx/lvKsbjptlr6gSOs37KWLw/aLyT6+pjHf5dP3t6yd8RTbhxpP1x19WDJ OUYlluKMREMt5qLiRABsXS2bFwIAAA== X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD047;1:ObRDYajeE3v4GQGLAx07URAHUjBvsjzUYhsn+1FUN5QCG8ry2dDMeZV5Uhvr9l+uAgHduciYeZs9G/hTfYyCcgWEcTYdRlG2yjvlCoTcEa2k1AGbNBQZhbbcg7KTmAFQkTQ0Vdz0W/rfAcTFVpoK+bh1KesCYQT6TNC3kR7z6kss4osOR14r30+5aY7/CfPpE5tISrOUlbUaZlslvV1+UNJ1MbTNEwARDseMIvUPhsWOtMH9GKMmQBvLfBYUYd5dSP/ZJ3ArrqjYpqvkFxndz8bo/PeExYE36cHz8bH577+H1z9pn2dt1HmYUWWPf55E5VStt5eWnlv8ieMzyhdzspJCvycW/3m3LJLZql3KN4IOh2wJZUBlKosJ9XmVCmNv6jkG87D2awapySjrHoKQqg== X-Forefront-Antispam-Report: CIP:63.163.107.172;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(51884002)(24454002)(199003)(377454003)(189002)(479174004)(83506001)(54356999)(586003)(4001350100001)(50986999)(2950100001)(65816999)(87936001)(93886004)(11100500001)(76176999)(106466001)(5008740100001)(5007970100001)(36756003)(5001770100001)(1691005)(80316001)(189998001)(69596002)(50466002)(230700001)(81156007)(4001450100002)(97736004)(5001960100002)(65806001)(59896002)(92566002)(87266999)(64126003)(77096005)(65956001)(23746002)(86362001)(33656002)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0201MB0761;H:milsmgep11.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0761;2:FScpk84muX+nsFhWYO3C/xin/ck14x/0wZ+B5TDbKHSxJoGQYaCudl+RZR2IwzTeTJBP6cu1W1JleANwXWHZy0da52XxQbr1JiudfhA+FoJ2tMzS2ds1XnIFNKe1e0RSVh/DM/qS4iWYGa4WeXro1oshqeFaLutJtB6LpjzRolg=;3:kX5oWIcpmXRjGVxt0bctXOf4L6TLr+sBKWonM3ZVtqwnwSWjmCby/U3o4uYZmAJZ576BZ5PpPLcxt0xifKZ9fIJ5blxtRSQYdVHR3d5GnvYsyB2GGvkCO8/10XcVj0Ljaqj/Gy6RGUL6tyuaCCFqTNCof9sGLDX0FUpPPF/B59+8PeRcgfQ7ZggYzf7nb2pJ6VzrQs2NNq+r5KgsEGA9fqCuXgpoQ61yyoxcrrj0S5StJ/UY+qu2fnf4fnWToL+BkjSWTkmAgcDVq0l+Qg98uw==;25:DFc7nOjyaz4odpiQD+40fsjbWf0DZIfRtA9/fpmlqfL8R5SZ5kR+jUkrSxp8zjvZRqT0h3f63nxAY8hmdSfQjWgbDSNngMr9RJZ33CdO7QerREydGrV9C2ePg3WYZtEiwlz1gU+FuaFJtulewjUz+R8b6Sy5DwpWfyR/8wuiggrQfaalJ0y6DQWhaCf7mFQ0hxS+LRYuo4M5w2ykjM4hk+uUBrbAmVUkcLQ1RzUhG/rXKfrfRqUO12TrFrYi0aQPJ50bMkkCnwYLECFMMesh/Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:CY1PR0201MB0761; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0761;20:ULzOL6tlCK1soOwvghcglgmJ0v4eSpA/f26s9lPMZQvjv0w731iTGw1/ZMUw/1LiENk0NyH6a+4J9j9LSDvLSCaj0Dq0nmQ9fF0nEDVCIxMUEiTHyJrBCPKzXiZ/GO7p+zUWL6nsRuZkvEyJVvwyZ25A3iXDJb4LeiN/hvUFE1xO5zfKRcIsu6q7FTVJisy2g6gU/N0dspw/MkjZLPs2+Gb2XMijg9eYyfzEOv/gE6PSOgoUdGcdDNKVxjguAwMh6ktrPF2Bx36j8MfyIq8kKcIl0jbuFMvKiB30Qp11whPD8zhxK7fm947/Ew6Me5e2Q2BgxRHfMhcQImHpAw5+wBB7XOamHOflMVdw9p+1ZHgHd1CHoQQa1HN6udwyWOC8Eyh2iIg+6PoWbVW1tTtKCS2bL5YQPKZ6X0MKAQoV3cbF7XRDNGjSKMkxWnnbUTT2S7Qv9w6DEFUonGI/xvIruuHlVjKEUzk0wGdOyGQAiUrvq4T6MJEDt1usuvAP68S/;4:+VBKnsuHyQQaRd82FgGTLm3kyfhHkFM/p2BzUS0MGzUaLPFlErTPz8jLABBg2F8AgzaT+n2vihVEWJz4sbjdE+j6Q7S5ba0ZKvweZ1P4/Kf/wpM15GVTXnoJoWTiD9QHrrArPeCKH7nHL7YmJit9NHq0++0hfEg4SRvnNE0/5sjOP7YVtb7qpnfX8D5YoNg/L0xSHGzPrhZSChlL/a4zLZWZxv9dsQWrQvqAkm8ibdFPoo8YzctzynHLiPtq9SZnsqRrNXCvWvgGDoCqKYA3L6oCNxDnvO29Pyljd1p+pXH9LWWrgRXUCLzWkcj5yxrHWhJyvNbjwMg6R/xcJYLlHhtkSZCnbjb6GSNjDaWEJnYeqQDmQFv47JArm74B3Lwn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046);SRVR:CY1PR0201MB0761;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB0761; X-Forefront-PRVS: 07630F72AD X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR0201MB0761;23:CxPt5SBQukTPsisuC9taNQT+8CY/Top5nn+?= =?Windows-1252?Q?JEYFwjz2ri5tAyDLWbUm0RAuSUSqh68jB9vYXbILgJWiv1xOrJbmZnWC?= =?Windows-1252?Q?Q6dN06SLlPfSeVKSuwyWfU+Drck5Mx2k083dC4K5y+7O+ZjArrZyXSXd?= =?Windows-1252?Q?wBoPxRP34K8WqQPyK8Jq7/ufuUeoCXHoJhWQ0KGMz2+DJDK1OurqmAB7?= =?Windows-1252?Q?DKR6lz033dY5z3q0no48p4wUIn1h3Wr6v1bJKHnsThIPPuexZVvprEyd?= =?Windows-1252?Q?yc+ezJ1C6BgUUx3CPl2ClZrbLwizjmXkBBOLpEtqYGDUsOq/UiF9jHpo?= =?Windows-1252?Q?XZTKeM5qRWxd0JBNerd5MatGC8mIbT6yfmqdN84m+POtwP64trCU3X58?= =?Windows-1252?Q?/kjqA1D6azHWUXDNd/Qf7dxwbTZpLl4LovwbZugFi6KYYQdb21vCrEXt?= =?Windows-1252?Q?tvY7RwIejBVRCQoEtkUFGnlI3UFsCWCIBQ/3+uvLpXKtYtBiFfXcXD1H?= =?Windows-1252?Q?H7HJpNwKL6MV9UOJB/nlrHooLiCmqJTRpLvxpUxi4sJYTv+FjdRABf7H?= =?Windows-1252?Q?kHqCQYzdCcZ9H7in2nrseM6MqqB9niSDNuUv+4It9XHQ9WZBreIPVtrW?= =?Windows-1252?Q?rUiy/sdikqmHiLHfJPe0+et5Mkb52PPBuyvT5IrsdywHIIzDRpmT3pXs?= =?Windows-1252?Q?RzLTHEBR/bWFhGVEbdChKEUwhflVoeEXZiZMjB5UHUk+PjU0sinOQQ5U?= =?Windows-1252?Q?PF59tMGFynGaqHP/4CqBTqfT9InkopzocAbWap7RusDjEslDUEmpRxi+?= =?Windows-1252?Q?l8no2p2HXdMFOqGMh6Gq1PXAv8XCflniXZIqgX1Y27CRyP/r7ub/Oc5B?= =?Windows-1252?Q?fNrwlgBuIYx8MJB1G1PRLYtDnH/TydkXXXFnyiVODPQMd+dsdpUlwDHa?= =?Windows-1252?Q?5P6p2ODvPCzmJxP2LXkovc9lLn/xB4HYhgoibPi/DIukcgYekMU8h3qu?= =?Windows-1252?Q?vu9RMkrE6ElNsG7x0x4KCLY3d2qc6M4AXPfAt+rvQepRwItGhVGaZyyn?= =?Windows-1252?Q?taJAecGgKnjaLO4voAaoHLV2thKXie9pKFVDgmM5M6bQpJ5zFrIQkVdg?= =?Windows-1252?Q?PhzLfgHTnkDB+cKnMkyM8z3HSxlguMpMOw1y35BSJAfZUDF5dz9vpqUK?= =?Windows-1252?Q?wPlki2i8MR7+KxXHLN+4gnuZHARwcJNnwyXsCHWhSLl5ijcW4bvnxmp2?= =?Windows-1252?Q?azkkefsOA/uQpglFvEubaAcDZXiA9Eur0G5nAqig4qLEYAVFzL/zsOqc?= =?Windows-1252?Q?1reXdc5T6dDC0d0MR7wH/lwzXuQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0761;5:WlMPrsk+YjlM3VlADyulbzEhYIIH4ZJLvc3+YJBHONbNGHbHmaj8GL2T9P7vrcY1P6z0iPtQRy1x2WDltlw9wSJ900Ugzjuxk3OdLlAPlgfap6tzSMyogwI4VqOqitiIZ8AEtZmFHBYXZkcMhK7h1Q==;24:58SqrQHxs4c/eN5YKsxSbpZbYmLbuoCDzhmbt+lNyhTASxAWn1tQNusEu56ECo1wRb5LsKDCYPhclgYDb3izHUe+WPFh1e4KpZc6S6MYyAY=;20:LsjniekgXVRMkg8ysbSqqHsTW8faNJm7GzZjigjI+tXTCmI73dhgs8h7oygfRKg6F0/s8iIAuz6f0xdrMLMiDyASNpc5n5nIUO43F8vZ67muhYFwbrtRHK9e81cDhcw4PMOQNOOnF90qA/CjllEAWKSP4TEjdgnmaeHVuJCr97r1QxfpDeYV9PNcscMdreLtO5fCCeO/bvGKzL98MCeS5pyEP236fl7kFq2pV2t0Nku35cIEl7QEp6AAvKDb/Pqf SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2015 17:16:29.3638 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.172];Helo=[milsmgep11.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB0761 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/2015 11:02 PM, Christoph Hellwig wrote: > On Fri, Nov 13, 2015 at 11:19:24AM -0800, Bart Van Assche wrote: >> On 11/13/2015 05:46 AM, Christoph Hellwig wrote: >>> The new name is irq_poll as iopoll is already taken. Better suggestions >>> welcome. >> >> Would it be possible to provide more background information about this ? >> Which other kernel subsystem is using the name iopoll ? > > Take a look at include/linux/iopoll.h - I can't reaplly make much sense > of it to be honest, but it's used in a quite a few places. How about renaming blk_iopoll into blk_poll ? That way the name still refers to the block layer. And although the current implementation performs polling from IRQ context future implementations maybe will allow polling from thread context. Bart.