From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 5/9] srpt: use the new CQ API Date: Tue, 17 Nov 2015 11:38:48 -0800 Message-ID: <564B8248.7050407@sandisk.com> References: <1447422410-20891-1-git-send-email-hch@lst.de> <1447422410-20891-6-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447422410-20891-6-git-send-email-hch@lst.de> Sender: linux-scsi-owner@vger.kernel.org To: Christoph Hellwig , linux-rdma@vger.kernel.org Cc: sagig@dev.mellanox.co.il, bart.vanassche@sandisk.com, axboe@fb.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On 11/13/2015 05:46 AM, Christoph Hellwig wrote: > [ ... ] This patch contains two logical changes: - Conversion to the new CQ API. - Removal of the ib_srpt_compl thread. Had it been considered to implement these changes as two separate patches ? Thanks, Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754588AbbKQTyx (ORCPT ); Tue, 17 Nov 2015 14:54:53 -0500 Received: from mail-bl2on0055.outbound.protection.outlook.com ([65.55.169.55]:38304 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752148AbbKQTyv (ORCPT ); Tue, 17 Nov 2015 14:54:51 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; lst.de; dkim=none (message not signed) header.d=none;lst.de; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-f79f76d000007db2-2a-564b8248c26b Subject: Re: [PATCH 5/9] srpt: use the new CQ API To: Christoph Hellwig , References: <1447422410-20891-1-git-send-email-hch@lst.de> <1447422410-20891-6-git-send-email-hch@lst.de> CC: , , , , From: Bart Van Assche Message-ID: <564B8248.7050407@sandisk.com> Date: Tue, 17 Nov 2015 11:38:48 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447422410-20891-6-git-send-email-hch@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42JZI8azSNejyTvMYGefvsX/PcfYLFauPspk cXnXHDaLZ4d6WSy6r+9gs3h9/CmTA5vH9BmbWD0mNr9j99h9s4HN4/MmuQCWKC6blNSczLLU In27BK6MttsnmQqmMlUsX/eKrYHxBmMXIyeHhICJxKYvM5ggbDGJC/fWs4HYQgInGCVm/Urq YuQCsncwSpy4s4wNpuH6sb9QRZsYJe6uMQaxhQUMJQ5P/80OYosIOEjM+DSTHaImW6JlwiY2 kEHMAj2MEkfv7QfbzCZgJPHt/UwWEJtXQEti5YlmVhCbRUBV4sKqs2ALRAUiJCZOaGCFqBGU ODnzCVg9p4C1xJU9T4Gu5gAaai/xYGsZSJhZQF5i+9s5zCC7JAQuskq8nryAEeIIdYmTS+Yz TWAUmYVk1CyE9llI2hcwMq9iFMvNzCnOTU8tMDTSK07MS8ksztZLzs/dxAiOGa7MHYwrJpkf YhTgYFTi4RU47hUmxJpYVlyZe4hRgoNZSYSX08o7TIg3JbGyKrUoP76oNCe1+BCjNAeLkjiv dYtamJBAemJJanZqakFqEUyWiYNTqoFxrm+FbPCHOc7vQ4NOfkrntjzo/75+y02TnguB8ouv NLDInW5+cVL32GoTsbaYxala6ts5dyV23CreZRxWwbgisXfP6SzbjKUxH3OjjAvvnzDNyalJ +8gclhecb1szpzn5xNtLRwp+Hpto7jx/goLujWsaN4wdGNn/sCx50vPLoXkGK8e9RQxKLMUZ iYZazEXFiQBbJRrulQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplluLIzCtJLcpLzFFi42Lh2siRouvR5B1msG6BksX/PcfYLA7+bGO0 WLn6KJPF5V1z2CyeHeplsei+voPN4vXxp0wO7B7TZ2xi9ZjY/I7dY/fNBjaPaWvOM3l83iQX wBrFZZOSmpNZllqkb5fAldF2+yRTwVSmiuXrXrE1MN5g7GLk5JAQMJG4fuwvG4QtJnHh3nog m4tDSGADo8TUiy1gCWEBQ4nD03+zg9giAnYS6183sYLYQgLZEi0TNoE1MAs0MUrc+7oTrIFN wEji2/uZLCA2r4CWxMoTzWANLAKqEhdWnQWrERWIkJg4oYEVokZQ4uTMJ2D1nALWElf2PGUC sZkFbCXuzN3NDGHLS2x/O4d5AiP/LCQts5CUzUJStoCReRWjWG5mTnFuemaBoZFecWJeSmZx tl5yfu4mRnBAc0btYLw+0fwQIxMHp1QDo3VYc/YBl8wFHn6H1rXwZlho7X1kyvGiMnGKZPFr J+Wcs490k3rObUh8x23y9YBmwITiO639IfY7RCvuam+auW/SmnMtD8/oMWscYO4+tdjY86+5 2akE113Vv4u3LInSStks3ztr+4FDBw8sCV4dK24h4xAmIFblZZyx7qFRbqlERcqSMzvXKLEU ZyQaajEXFScCAFzBFcYYAgAA X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD040;1:SZzX4mJ7Fdz9Bq+2ug2pewvD9X8Evo1BPwiYwSuRhceXMqv2AItswFGCQFhn7ND7MIGnFg8l58Tp+XOdRtNIspa9CreG29AvaCuEdWmFCAvO8vDj8YXFXQzkzvcy6/TdDpnGdWkvsJFBRVqFRvNRhmLh9F6X9WjkqvWef/olPxAJFz34AeYZV4Di3Q9bXxwRMBw6zJ89/xfrYdIhnv1GrB7r4Kj9pFO+nYEcHr6QEwRYPuYO6/SrYGng2NTnVQ5Y5jHNr2DjOAu2CU00ZYD4E4ppYvF52zAX6dDS6WR5RabE5MFM5vepF5wBniQr9OQ9LoQePY+u2MtsKN8MOmHznCuD34kZO65RplTbYrphVWM= X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(164054003)(24454002)(189002)(377454003)(479174004)(87936001)(92566002)(54356999)(230700001)(189998001)(5007970100001)(76176999)(97736004)(558084003)(2950100001)(77096005)(50466002)(4001350100001)(59896002)(81156007)(5001960100002)(5001770100001)(86362001)(83506001)(50986999)(64126003)(5008740100001)(33656002)(106466001)(23746002)(65816999)(36756003)(87266999)(65806001)(69596002)(586003)(11100500001)(47776003)(65956001)(80316001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR0201MB0753;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0201MB0753;2:0U9JC/Sh4SQxEzqzu6CzHTrgJBV3c6Va9vji+mOkoq/R4uuEb165FQ4Hu9VOmqMLr6537c44PJNLWlitXhF9rwN2rgkLEKJpfak/etJYbNSQ7xgzK6rLRghXJpuIHSTVPUqHKnNabuSYLxQhK0Ld6bF9vAxGm+BlHjPjwgd7l+k=;3:ZDk3v3C+vMEGKFogUTkRybdwrsfetD5WIyGR08pDZOs8HBn9kQx1VqXwb2gOg46TP+sIDq8duC+ki7fpfzHx4NGLoSqdDUl/cl0TbN69BjfehX9cjIBtFgG+JEb0OiGYcEC212QgEqDFWWct7wltE4+/AxRHBCsc7dfv2tVLM/Hn4gh7bclAq60uyIXYz2l+Df67HEPwEelPj+yPquR/dMEETwOEPbEclp1TMI5tUQPeAEWzsImbr+tE9TXsVgTJMKdqhnLBoqYhyQ6Jb7KSjw==;25:gmd/wY8iAD4gYrXIqZSl6zSeq/EnynaPdlyItF3PletX1VI+km8hzt0MXwhMCNeDIR1DgAmJM4i7rvi/JmQvG0qvV44oYfHiRcVRloShCHmfqtP4e20nxMP/RzJTuoCt9BXE5DQlJb/SdGZEILIabcff4OGyciSoGl5xbFU6SqAi36nHVtO2Z8LxP7AwsqMmxUGJeylZuKFyoES5ImBYPNAfXWRh/mdPBULNe/0EgUVHEv5nwvWQ2I/BInGCq1JCTDQj33LfgayhJS06w+r1wA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN1PR0201MB0753; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0201MB0753;20:btrvIKyxiiM08Nsy0oWNxmoAbe+k6dt8elz9WTj/esvcTpThn7a5dMpQKO3UbvK1LadsysE+1qtQd4fFLIte+/wBFlCrtb5F7BaAUSvHijjWJCpvkZYp/4O36cnUTV4E0EDvGrP+lOpb4JrPaoERTxEgwCkMWVwfkwLYuX41Qa1GuV81DQuzpAv4EgNItPWP0K/deXBKkI2bwqzPtjLn8kYvcrXr3h8trGVXoX1AtpIWVqxOQgvyjzEfDoNNIvbAb2l6YSGmYyNYWcL9JWfAveKSv9tGplT+s6+MXTqti9s7TcDTw6X4H26Ygiy1HqBXzcxoOcfMeX5EL0SmQ0E5W7WyQJmNvcvioRfX9F1e8gwjwykXz55qyzkAuvOZbpjguADDe6JXWGb7DUaXx2D/LJGIIYy5m6FZJmm7I9aMjGQdWZHxC67nZfuKTq4hBksFHtIce0cGkouv03oGJdvhJOldHvYjID5cUdqSuni5Iy1s/c4SShfAvrRARx58wfT7;4:bCw7hDB3hltXWI6Bsz4CmhTguTgpYt+DlE3MWd+WU2nxS1jy6/hMciYxEr9oUFhi9hJF+WCRXGYvVd0oQ0So3OfbLTdWoofECLNLXLmzgYQY/Ih0adWGbGfg64IKIv6jm5J5HpytCsmiRTwIqmy3Z9zL67ZFmr09pbIsoHpEEXlKe3P8VBIMlLlwg2G+cs3mvY8qUXL8OzoAgSc3qjCXuVSTJEVVZ20P1fPoNeRvQKhw4TNqQT1GXP4TBiusvwZLyf6Ax8/iah2ai9j16DW5ZzNQUv+1A/QgFTX25auDUB9aD+qXQejfAtCu4UwWjdHjAIqsPHb+ZSGjRfLFOnIqqCQ10HQNRkIGVEfbD1cCxjTiPv3zZ5goXuMPBxjv4BSE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN1PR0201MB0753;BCL:0;PCL:0;RULEID:;SRVR:BN1PR0201MB0753; X-Forefront-PRVS: 07630F72AD X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN1PR0201MB0753;23:NTmWKoOJKpDmkIjEHXFmC2AAG61KPD1/f2v?= =?Windows-1252?Q?4/i7NyAoNbu4QMGBvL4g6b0OTA9MBEjTNq71tWKxk/0gjPbIg2kUwjsO?= =?Windows-1252?Q?s26vfnlV3hPRho+K6t1bXMDpYE9FLGTNqUoQr2GvmL8qCLBk3zX3C0S6?= =?Windows-1252?Q?QVsA8TBOUKchSDKnqtGLmEVUFJ4CLyBvGEVroKTcYbN55TbOUve7gA6S?= =?Windows-1252?Q?8rw3UatHnUkDN0hQKGmhvV+oMeVIP9c6TaIKhZeHByDV8VbqXddNrXrm?= =?Windows-1252?Q?t4/vT0/FYHcjM6/pCSqozQ5opUlpUHc3HpcFbGKSVM/7SJtwxVluCE7U?= =?Windows-1252?Q?JrDd/tzrYJ2PDTpaH+JJ97FKSXH54lkGvmYz5nRMqDK/E/iED9oFrR9v?= =?Windows-1252?Q?TPZ2ZFYWrnM3CqrlqUWskTm98gfhexV4w5MWjyOzo5BcAq4LNgNjd9rx?= =?Windows-1252?Q?8AWUJzxBvtwM7DvlhQ+0L0jUSYD0I7Il4Do4XAwR88UqAkRI6WbyrsMN?= =?Windows-1252?Q?FvuAXtrbEg36YvbuE62GOahMNaODgxwCZvnVhHLtSS2VXcc+PL7jFt66?= =?Windows-1252?Q?xb2Xg469O6/m4wkKRSSFOLA9MC8O0N86odukPGWqNcjCago2wO2fjJ8o?= =?Windows-1252?Q?IcbvTD3fqfirUX2Igfrmh/G2RTmtvhKu6ZyACSWMmKF4n1rSdaodBDrF?= =?Windows-1252?Q?NUmOwsqIGVtVmGtzGeRY6wL77/1mRDkGWrnOEtdY/z4Sw+FGu9Gizayo?= =?Windows-1252?Q?HqTdv/urBu+fzckZaVgfBjOnn6RUk/hTpk1knvFPEp+q0RxBXKiM3cG+?= =?Windows-1252?Q?mW9VjQKgfy94QvAZp4MLlcL7g+IyuII0Vechmzw3wVL+bULopv/aLKy+?= =?Windows-1252?Q?3YmNQU4bdnzx+lggpd7h8ltUmuUxdn/pdetjODZc9KvzrW/OetOoMKSs?= =?Windows-1252?Q?yFk+930i51hXOrDtshGvKyQlSEv/EysFodTnziCdKTnkLjjN16Jk/FqQ?= =?Windows-1252?Q?4O5I9cwBzPbYVG2Nrar1NqsJcyDUvfMfQM5KPhnhtmtOhNfespCy2OgS?= =?Windows-1252?Q?B/cj/WYYpPJqzMHIgP1lzu/AU6dPD8mzyF2wmPFvIukc2hCU4BYUb5HV?= =?Windows-1252?Q?0LvzeBYykGCG965M+IbO3qD7sDJZ50bDG1AD2w8pOBrb1M1JZucuC9Wa?= =?Windows-1252?Q?/FMAF4zISkNAZOLzH31ygHmKk39KSIQjzPV6ueC3wArTj+YHSp5/51dO?= =?Windows-1252?Q?DXgGQoEA/TCqAuWFZ3Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR0201MB0753;5:IRN8137ZTgY9WpR6nvTOxcbjfcSWiD2a0ZHMroRSRV48OMocXqIWbkRWFj23VtUF1Exzi2t2HbbCp/+vmF8CLcZV/oeMWOPM6pFG9lsNMXl3jlcEsv857MnBzL9lf4VnSoG4mVb53RGAqix67fmA6g==;24:+AUcFF/Vc04NDdLI/4Z0uD3dpTATnsjHze4BwVFLh23Ts01FEbMtDpjG9DLXNpH2cfEfG96+FVwQNHaTyUEOWF55qRD9HJ3gtFdf+9VQPmU=;20:F59taFr5511RiUtvWHJXfoY6fB9BI3ISgwrD5TXwYogMVfJc22P6Da1XzCfMJ+o7w/yzgSrjTs+k55/QDsXsoS4kDIgSKZONVt8TcBXTCOshfsQJpe4oTbDVjWVpSYe2Qt3AmidkwW011mGXEIrr6dMULDmgOySFM0AIOy1f53b046aO1FcaoJRrN7PxfYvfkB84MHq4qfkl15p39tAePG7GLDC4g645bRHt4OfmwPudMX6+kr/ROy44i9QpH/6e SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2015 19:38:48.6015 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0201MB0753 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/2015 05:46 AM, Christoph Hellwig wrote: > [ ... ] This patch contains two logical changes: - Conversion to the new CQ API. - Removal of the ib_srpt_compl thread. Had it been considered to implement these changes as two separate patches ? Thanks, Bart.