From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chun Yan Liu" <cyliu@suse.com>
Subject: Re: [PATCH V8 3/7] libxl: add pvusb API
Date: Tue, 17 Nov 2015 22:48:59 -0700
Message-ID: <564C81CB0200006600084926@relay2.provo.novell.com>
References: <1445418510-19614-1-git-send-email-cyliu@suse.com>
	<1445418510-19614-4-git-send-email-cyliu@suse.com>
	<20151113111921.GA16965@aepfle.de> <5649A988.7010609@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5649A988.7010609@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>, George Dunlap <george.dunlap@citrix.com>
Cc: Juergen Gross <JGross@suse.com>, wei.liu2@citrix.com, ian.campbell@citrix.com, george.dunlap@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, Jim Fehlig <JFEHLIG@suse.com>, Simon Cao <caobosimon@gmail.com>
List-Id: xen-devel@lists.xenproject.org



>>> On 11/16/2015 at 06:01 PM, in message <5649A988.7010609@citrix.com>, George
Dunlap <george.dunlap@citrix.com> wrote: 
> On 13/11/15 11:19, Olaf Hering wrote: 
> > On Wed, Oct 21, Chunyan Liu wrote: 
> >  
> >> Add pvusb APIs, including: 
> >  
> >> @@ -635,6 +664,8 @@ libxl_domain_config = Struct("domain_config", [ 
> >>      ("pcidevs", Array(libxl_device_pci, "num_pcidevs")), 
> >>      ("rdms", Array(libxl_device_rdm, "num_rdms")), 
> >>      ("dtdevs", Array(libxl_device_dtdev, "num_dtdevs")), 
> >> +    ("usbctrls", Array(libxl_device_usbctrl, "num_usbctrls")), 
> >> +    ("usbs", Array(libxl_device_usb, "num_usbs")), 
> >  
> > Should that perhaps be "usbctrls" + "usbdevs" if the latter really 
> > represents a device below one of the "usbctrls"? I dont know if it does, 
> > just wondering. 
>  
> That seems like a reasonable suggestion. 

OK. I'll update "usbs" to "usbdevs".
I think libxl_device_usb doesn't need to be changed into libxl_device_usbdev? 

>  
>  -George 
>  
>  
> _______________________________________________ 
> Xen-devel mailing list 
> Xen-devel@lists.xen.org 
> http://lists.xen.org/xen-devel 
>  
>