From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933469AbbKROtE (ORCPT ); Wed, 18 Nov 2015 09:49:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:44135 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932767AbbKROtA (ORCPT ); Wed, 18 Nov 2015 09:49:00 -0500 Subject: Re: [PATCH 1/2] mm: get rid of __alloc_pages_high_priority To: mhocko@kernel.org, Andrew Morton References: <1447680139-16484-1-git-send-email-mhocko@kernel.org> <1447680139-16484-2-git-send-email-mhocko@kernel.org> Cc: Mel Gorman , David Rientjes , linux-mm@kvack.org, LKML , Michal Hocko From: Vlastimil Babka Message-ID: <564C8FD9.3060706@suse.cz> Date: Wed, 18 Nov 2015 15:48:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447680139-16484-2-git-send-email-mhocko@kernel.org> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/2015 02:22 PM, mhocko@kernel.org wrote: > From: Michal Hocko > > __alloc_pages_high_priority doesn't do anything special other than it > calls get_page_from_freelist and loops around GFP_NOFAIL allocation > until it succeeds. It would be better if the first part was done in > __alloc_pages_slowpath where we modify the zonelist because this would > be easier to read and understand. Opencoding the function into its only > caller allows to simplify it a bit as well. > > This patch doesn't introduce any functional changes. > > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by kanga.kvack.org (Postfix) with ESMTP id 56E5382F84 for ; Wed, 18 Nov 2015 09:49:02 -0500 (EST) Received: by wmvv187 with SMTP id v187so282035563wmv.1 for ; Wed, 18 Nov 2015 06:49:01 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id j62si5272854wmd.65.2015.11.18.06.48.59 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 18 Nov 2015 06:48:59 -0800 (PST) Subject: Re: [PATCH 1/2] mm: get rid of __alloc_pages_high_priority References: <1447680139-16484-1-git-send-email-mhocko@kernel.org> <1447680139-16484-2-git-send-email-mhocko@kernel.org> From: Vlastimil Babka Message-ID: <564C8FD9.3060706@suse.cz> Date: Wed, 18 Nov 2015 15:48:57 +0100 MIME-Version: 1.0 In-Reply-To: <1447680139-16484-2-git-send-email-mhocko@kernel.org> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: mhocko@kernel.org, Andrew Morton Cc: Mel Gorman , David Rientjes , linux-mm@kvack.org, LKML , Michal Hocko On 11/16/2015 02:22 PM, mhocko@kernel.org wrote: > From: Michal Hocko > > __alloc_pages_high_priority doesn't do anything special other than it > calls get_page_from_freelist and loops around GFP_NOFAIL allocation > until it succeeds. It would be better if the first part was done in > __alloc_pages_slowpath where we modify the zonelist because this would > be easier to read and understand. Opencoding the function into its only > caller allows to simplify it a bit as well. > > This patch doesn't introduce any functional changes. > > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org