Re: [Qemu-devel] [PATCH for 2.9 v8 0/10] dataplane snapshot fixes

["Denis V. Lunev" <den@openvz.org>]

On 11/18/2015 06:24 PM, Juan Quintela wrote:
> "Denis V. Lunev" <den@openvz.org> wrote:
>> On 11/18/2015 05:31 PM, Juan Quintela wrote:
>>> Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
>>>> On Tue, 17 Nov 2015 12:08:20 +0300
>>>> "Denis V. Lunev" <den@openvz.org> wrote:
>>>>
>>>>> with test
>>>>>       while /bin/true ; do
>>>>>           virsh snapshot-create rhel7
>>>>>           sleep 10
>>>>>           virsh snapshot-delete rhel7 --current
>>>>>       done
>>>>> with enabled iothreads on a running VM leads to a lot of troubles: hangs,
>>>>> asserts, errors.
>>>>>
>>>> In my case, when using a virtio-blk-dataplane device, calling savevm *always*
>>>> result in a QEMU hang.
>>> Oops
>>>
>>>> With this series (plus the s/bs/bs_vm_state/ change in patch 11), savevm/loadvm
>>>> now works like a charm.
>>> Nice, thanks for the testing.
>>>
>>>> I saw that Juan does not like aio_context being used in migration code, but
>>>> in case this series gets applied anyway:
>>>>
>>>> Tested-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
>>> I *think* that we should get better API's exported from block layer, but
>>> *at least* we will get this series in.
>>>
>>> Thanks, Juan.
>> that is good to me. Current block level API is terrible and unclear.
>>
>> Greg is correct there.
>>
>> Should I resubmit the last patch or you will change this yourself?
> Please, test and resend.
>
> I am not have lots of experience testing that.
>
> Thanks, Juan.
perfect! Give me 2-3 hours pls.