From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933579AbbKRQgZ (ORCPT ); Wed, 18 Nov 2015 11:36:25 -0500 Received: from smtp113.iad3a.emailsrvr.com ([173.203.187.113]:57405 "EHLO smtp113.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933515AbbKRQgU (ORCPT ); Wed, 18 Nov 2015 11:36:20 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro To: Ranjith Thangavel , gregkh@linuxfoundation.org References: <1447692975-6515-1-git-send-email-ranjithece24@gmail.com> Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <564CA901.4040104@mev.co.uk> Date: Wed, 18 Nov 2015 16:36:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447692975-6515-1-git-send-email-ranjithece24@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/11/15 16:56, Ranjith Thangavel wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith Thangavel > --- > drivers/staging/comedi/drivers/ni_6527.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/ni_6527.c b/drivers/staging/comedi/drivers/ni_6527.c > index 62a817e..84c62e2 100644 > --- a/drivers/staging/comedi/drivers/ni_6527.c > +++ b/drivers/staging/comedi/drivers/ni_6527.c > @@ -42,24 +42,24 @@ > #define NI6527_DO_REG(x) (0x03 + (x)) > #define NI6527_ID_REG 0x06 > #define NI6527_CLR_REG 0x07 > -#define NI6527_CLR_EDGE (1 << 3) > -#define NI6527_CLR_OVERFLOW (1 << 2) > -#define NI6527_CLR_FILT (1 << 1) > -#define NI6527_CLR_INTERVAL (1 << 0) > +#define NI6527_CLR_EDGE BIT(3) > +#define NI6527_CLR_OVERFLOW BIT(2) > +#define NI6527_CLR_FILT BIT(1) > +#define NI6527_CLR_INTERVAL BIT(0) > #define NI6527_CLR_IRQS (NI6527_CLR_EDGE | NI6527_CLR_OVERFLOW) > #define NI6527_CLR_RESET_FILT (NI6527_CLR_FILT | NI6527_CLR_INTERVAL) > #define NI6527_FILT_INTERVAL_REG(x) (0x08 + (x)) > #define NI6527_FILT_ENA_REG(x) (0x0c + (x)) > #define NI6527_STATUS_REG 0x14 > -#define NI6527_STATUS_IRQ (1 << 2) > -#define NI6527_STATUS_OVERFLOW (1 << 1) > -#define NI6527_STATUS_EDGE (1 << 0) > +#define NI6527_STATUS_IRQ BIT(2) > +#define NI6527_STATUS_OVERFLOW BIT(1) > +#define NI6527_STATUS_EDGE BIT(0) > #define NI6527_CTRL_REG 0x15 > -#define NI6527_CTRL_FALLING (1 << 4) > -#define NI6527_CTRL_RISING (1 << 3) > -#define NI6527_CTRL_IRQ (1 << 2) > -#define NI6527_CTRL_OVERFLOW (1 << 1) > -#define NI6527_CTRL_EDGE (1 << 0) > +#define NI6527_CTRL_FALLING BIT(4) > +#define NI6527_CTRL_RISING BIT(3) > +#define NI6527_CTRL_IRQ BIT(2) > +#define NI6527_CTRL_OVERFLOW BIT(1) > +#define NI6527_CTRL_EDGE BIT(0) > #define NI6527_CTRL_DISABLE_IRQS 0 > #define NI6527_CTRL_ENABLE_IRQS (NI6527_CTRL_FALLING | \ > NI6527_CTRL_RISING | \ > Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-