From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757660AbbKSECA (ORCPT ); Wed, 18 Nov 2015 23:02:00 -0500 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:44224 "EHLO tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbbKSEB6 (ORCPT ); Wed, 18 Nov 2015 23:01:58 -0500 Subject: Re: [PATCH 02/10] KVM: x86: MMU: Add helper function to clear a bit in unsync child bitmap To: Xiao Guangrong , pbonzini@redhat.com References: <20151112204849.ba920599a8426d7196a0df73@lab.ntt.co.jp> <20151112205019.611e8216adebb465b689876e@lab.ntt.co.jp> <564BE628.1050705@linux.intel.com> <564D1EF7.4000707@lab.ntt.co.jp> <564D3816.8080609@linux.intel.com> Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Takuya Yoshikawa Message-ID: <564D49ED.3020101@lab.ntt.co.jp> Date: Thu, 19 Nov 2015 13:02:53 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <564D3816.8080609@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/11/19 11:46, Xiao Guangrong wrote: >> Actually, some people prefer to put braces when one of the >> if/else-if/else cases has multiple lines. You can see >> some examples in kernel/sched/core.c: see hrtick_start(), >> sched_fork(), free_sched_domain(). >> >> In our case, I thought putting braces would align the else-if >> and else and make the code look a bit nicer, but I know this >> may be just a matter of personal feeling. >> >> In short, unless the maintainer, Paolo for this file, has any >> preference, both ways will be accepted. > > The reason why i pointed this out is that it is the style documented > in Documentation/CodingStyle: > | Do not unnecessarily use braces where a single statement will do. > | > | if (condition) > | action(); > | Ah, this is a different thing. For this case, there is a consensus and checkpatch will complain if we don't obey the rule. What I explained was: if (condition) { line1; line2; // multiple lines } else if { single-line-statement; -- (*1) } else single-line-statement; -- (*2) For (*1) and (*2), especially for (*1), some people put braces. > Actually, Ingo Molnar hated this braces-style too much and blamed > many developers who used this style (include me, that why i was > nervous to see this style :( ). I think he likes the coding style of kernel/sched/core.c very much, as you know. Actually that is one reason why I took it as an example. Let's just choose the way which Paolo prefers for this time, I don't know which is better. Thank you, Takuya