From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934138AbbKSNle (ORCPT ); Thu, 19 Nov 2015 08:41:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:54434 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934018AbbKSNlc (ORCPT ); Thu, 19 Nov 2015 08:41:32 -0500 Message-ID: <564DD18A.40909@suse.de> Date: Thu, 19 Nov 2015 14:41:30 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET_BOOT References: <20151118083455.331768508@telegraphics.com.au> <20151118083457.891774987@telegraphics.com.au> In-Reply-To: <20151118083457.891774987@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2015 09:35 AM, Finn Thain wrote: > The atari_NCR5380.c core driver now takes care of bus reset upon driver > initialization if required (same as NCR5380.c). Move the Toshiba CD-ROM > support into the core driver, enabled with a host flag, so that all > NCR5380 drivers can make use of it. > > Drop the RESET_BOOT macros and the ATARI_SCSI_RESET_BOOT and > ATARI_SCSI_TOSHIBA_DELAY Kconfig symbols, which are now redundant. > > Remove the atari_scsi_reset_boot(), mac_scsi_reset_boot() and > sun3_scsi_reset_boot() routines. None of this duplicated code is needed > now that all drivers can use NCR5380_maybe_reset_bus(). > > This brings atari_scsi, mac_scsi and sun3_scsi into line with all of the > other NCR5380 drivers. > > The bus reset may raise an interrupt. That would be new behaviour for > atari_scsi only when CONFIG_ATARI_SCSI_RESET_BOOT=n. The ST DMA interrupt > is not assigned to atari_scsi at this stage, so > CONFIG_ATARI_SCSI_RESET_BOOT=y may well be problematic already. > Regardless, do_reset() now raises and clears the interrupt within > local_irq_save/restore which should avoid problems. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/Kconfig | 17 ----------- > drivers/scsi/NCR5380.c | 17 +++++++++-- > drivers/scsi/NCR5380.h | 1 > drivers/scsi/atari_NCR5380.c | 22 +++++++++----- > drivers/scsi/atari_scsi.c | 60 +++++---------------------------------- > drivers/scsi/mac_scsi.c | 65 ++++++------------------------------------- > drivers/scsi/sun3_scsi.c | 47 ------------------------------- > 7 files changed, 51 insertions(+), 178 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)