From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161175AbbKTQJ4 (ORCPT ); Fri, 20 Nov 2015 11:09:56 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34074 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbbKTQJy (ORCPT ); Fri, 20 Nov 2015 11:09:54 -0500 From: Don Brace X-Google-Original-From: Don Brace Subject: Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR To: Arnd Bergmann , "James E.J. Bottomley" , linux-scsi@vger.kernel.org References: <3970646.5sOyETUiWo@wuerfel> Cc: iss_storagedev@hp.com, storagedev@pmcs.com, linux-kernel@vger.kernel.org, martin.petersen@oracle.com, linux-arm-kernel@lists.infradead.org Message-ID: <564F45CE.3060402@pmcs.com> Date: Fri, 20 Nov 2015 10:09:50 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <3970646.5sOyETUiWo@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Don Brace And...Thanks! On 11/19/2015 04:04 PM, Arnd Bergmann wrote: > The hpsa driver recently started using the sas transport class, but it > does not ensure that the corresponding code is actually built, which > may lead to a link error: > > drivers/built-in.o: In function `hpsa_free_sas_phy': > (.text+0x1ce874): undefined reference to `sas_port_delete_phy' > (.text+0x1ce87c): undefined reference to `sas_phy_free' > drivers/built-in.o: In function `hpsa_alloc_sas_port': > (.text+0x1ceb9c): undefined reference to `sas_port_alloc_num' > (.text+0x1ceba8): undefined reference to `sas_port_add' > drivers/built-in.o: In function `hpsa_init': > (.init.text+0x8838): undefined reference to `sas_attach_transport' > (.init.text+0x8868): undefined reference to `sas_release_transport > > This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do > for all other drivers using those functions. > > Signed-off-by: Arnd Bergmann > Fixes: d04e62b9d63a ("hpsa: add in sas transport class") > --- > This showed up on the ARM randconfig builds today for the first time. > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index 04a720686516..64eed87d34a8 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -364,6 +364,7 @@ config SCSI_HPSA > tristate "HP Smart Array SCSI driver" > depends on PCI && SCSI > select CHECK_SIGNATURE > + select SCSI_SAS_ATTRS > help > This driver supports HP Smart Array Controllers (circa 2009). > It is a SCSI alternative to the cciss driver, which is a block > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: brace77070@gmail.com (Don Brace) Date: Fri, 20 Nov 2015 10:09:50 -0600 Subject: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR In-Reply-To: <3970646.5sOyETUiWo@wuerfel> References: <3970646.5sOyETUiWo@wuerfel> Message-ID: <564F45CE.3060402@pmcs.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Signed-off-by: Don Brace And...Thanks! On 11/19/2015 04:04 PM, Arnd Bergmann wrote: > The hpsa driver recently started using the sas transport class, but it > does not ensure that the corresponding code is actually built, which > may lead to a link error: > > drivers/built-in.o: In function `hpsa_free_sas_phy': > (.text+0x1ce874): undefined reference to `sas_port_delete_phy' > (.text+0x1ce87c): undefined reference to `sas_phy_free' > drivers/built-in.o: In function `hpsa_alloc_sas_port': > (.text+0x1ceb9c): undefined reference to `sas_port_alloc_num' > (.text+0x1ceba8): undefined reference to `sas_port_add' > drivers/built-in.o: In function `hpsa_init': > (.init.text+0x8838): undefined reference to `sas_attach_transport' > (.init.text+0x8868): undefined reference to `sas_release_transport > > This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do > for all other drivers using those functions. > > Signed-off-by: Arnd Bergmann > Fixes: d04e62b9d63a ("hpsa: add in sas transport class") > --- > This showed up on the ARM randconfig builds today for the first time. > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index 04a720686516..64eed87d34a8 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -364,6 +364,7 @@ config SCSI_HPSA > tristate "HP Smart Array SCSI driver" > depends on PCI && SCSI > select CHECK_SIGNATURE > + select SCSI_SAS_ATTRS > help > This driver supports HP Smart Array Controllers (circa 2009). > It is a SCSI alternative to the cciss driver, which is a block > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html