From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v3 2/4] xen/save: allow the usage of
 zeroextend and a fixup function
Date: Fri, 20 Nov 2015 08:41:40 -0700
Message-ID: <564F4D4402000078000B7454@prv-mh.provo.novell.com>
References: <1447864631-4174-1-git-send-email-roger.pau@citrix.com>
	<1447864631-4174-3-git-send-email-roger.pau@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1Zznok-0004yg-RS
	for xen-devel@lists.xenproject.org; Fri, 20 Nov 2015 15:41:42 +0000
In-Reply-To: <1447864631-4174-3-git-send-email-roger.pau@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 18.11.15 at 17:37, <roger.pau@citrix.com> wrote:
> +        if ( HVM_SAVE_HAS_COMPAT(_x) && d->length != HVM_SAVE_LENGTH(_x) )  \

If you broke this line at the && you could avoid all the churn to move
out the \ by a few spaces. That would also have avoided Andrew's
request for re-assurance that the addition here was the only actual
change.

Jan