From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Hq2-0005yx-KG for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:57:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1Hpz-0004Ba-8g for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:57:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1Hpz-0004BK-03 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:57:07 -0500 References: <144838492534.3052.2948919558518613064.stgit@localhost> <144838497636.3052.15443880874914788795.stgit@localhost> From: Eric Blake Message-ID: <5654A4F1.9090803@redhat.com> Date: Tue, 24 Nov 2015 10:57:05 -0700 MIME-Version: 1.0 In-Reply-To: <144838497636.3052.15443880874914788795.stgit@localhost> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3o6kNl2Ewx2PIkt9NtLtiNoErOJP7p0oo" Subject: Re: [Qemu-devel] [PATCH v2 09/10] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Eduardo Habkost , Stefan Hajnoczi , Markus Armbruster , Luiz Capitulino , Stefan Hajnoczi , =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3o6kNl2Ewx2PIkt9NtLtiNoErOJP7p0oo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/24/2015 10:09 AM, Llu=C3=ADs Vilanova wrote: > Each event with the 'vcpu' property gets a per-vCPU dynamic tracing sta= te. >=20 > The set of enabled events with the 'vcpu' and 'tcg' properties is used > to select a per-vCPU physical TB cache. The number of events with both= > properties is used to select the number of physical TB caches, and a > bitmap of the identifiers of such enabled events is used to select a > physical TB cache. >=20 > Signed-off-by: Llu=C3=ADs Vilanova > --- > +++ b/qapi/trace.json > @@ -29,7 +29,7 @@ > # > # @name: Event name. > # @state: Tracing state. > -# @vcpu: Whether this is a per-vCPU event (since 2.5). > +# @vcpu: #optional Whether this is a per-vCPU event (since 2.5). > # > # Since 2.2 > ## Spurious hunk? It looks like vcpu is always present on output, and that it is only... > @@ -42,13 +42,18 @@ > # Query the state of events. > # > # @name: Event name pattern (case-sensitive glob). > +# @vcpu: #optional The vCPU to check (any by default; since 2.5). =2E..the new input place where it is optional. 2.6. > # > # Returns: a list of @TraceEventInfo for the matching events > # > +# For any event without the "vcpu" property: > +# - If @name is a pattern and @vcpu is set, events are ignored. > +# - If @name is not a pattern and @vcpu is set, an error is raised. > +# > # Since 2.2 > ## > { 'command': 'trace-event-get-state', > - 'data': {'name': 'str'}, > + 'data': {'name': 'str', '*vcpu': 'int'}, > 'returns': ['TraceEventInfo'] } > =20 > ## > @@ -59,8 +64,10 @@ > # @name: Event name pattern (case-sensitive glob). > # @enable: Whether to enable tracing. > # @ignore-unavailable: #optional Do not match unavailable events with = @name. > +# @vcpu: The vCPU to act upon (all by default; since 2.5). 2.6 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3o6kNl2Ewx2PIkt9NtLtiNoErOJP7p0oo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVKTxAAoJEKeha0olJ0Nq9kIIAJxh5ZM57eVUjujhPODGWC1j OdHIUhCnXbIifpITUxA8tGaMyJLvenby5O4Law5XbrWrHkgi5DjRWWRerCXxuGHa HzJETm+oyNaQcVCk2pymwmE7FSDc15E05xpyE5IVF3DlXZLwvz0gVdHCJeBPtkuT PM8pHEBNuK+iLLY5hGnuZTtI6+z50L+O4ASle4REg1YeYK4wpMcSvcMfdiywDqxC tWTsPPS+WAqOk2d6gfhPzZ5E5jLvtftTupdROhuaKNKLl9E030eOUHz+z2cahdo9 GZH9Gd6y3BtXZe0kqp8LmrAcbtpurgSSL7CfYoAyrCGNzYDpJEJtkZeA7SyCoqM= =gKVn -----END PGP SIGNATURE----- --3o6kNl2Ewx2PIkt9NtLtiNoErOJP7p0oo--