From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1KUW-0003i9-32 for qemu-devel@nongnu.org; Tue, 24 Nov 2015 15:47:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1KUS-0007Y5-2Q for qemu-devel@nongnu.org; Tue, 24 Nov 2015 15:47:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1KUR-0007Y1-TA for qemu-devel@nongnu.org; Tue, 24 Nov 2015 15:47:04 -0500 References: <1448388281-18691-1-git-send-email-marcandre.lureau@redhat.com> <1448388281-18691-3-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <5654CCC0.2060000@redhat.com> Date: Tue, 24 Nov 2015 13:46:56 -0700 MIME-Version: 1.0 In-Reply-To: <1448388281-18691-3-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Vvmlqbp57CSxeCpNSteJ3eGmoe3a5WtCU" Subject: Re: [Qemu-devel] [PATCH v2 2/2] tests: add file-write-read test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Vvmlqbp57CSxeCpNSteJ3eGmoe3a5WtCU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/24/2015 11:04 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > This test exhibits a POSIX behaviour regarding switching between write > and read. It's undefined result if the application doesn't ensure a > flush between the two operations (with glibc, the flush can be implicit= > when the buffer size is relatively small). The previous commit fixes > this test. >=20 > Related to: > https://bugzilla.redhat.com/show_bug.cgi?id=3D1210246 >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > tests/test-qga.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++-- > 1 file changed, 93 insertions(+), 2 deletions(-) > + > + /* seek to 0 */ > + cmd =3D g_strdup_printf("{'execute': 'guest-file-seek'," > + " 'arguments': { 'handle': %" PRId64 ", " > + " 'offset': %d, 'whence': %d } }", > + id, 0, SEEK_SET); If my patch goes in first, you'll want this to be s/SEEK_SET/0/ to match. (If yours goes in first, I'll spin a v2 of my patch to cover all sites in the testsuite that need munging). https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg05454.html With that figured out, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Vvmlqbp57CSxeCpNSteJ3eGmoe3a5WtCU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWVMzAAAoJEKeha0olJ0NqrwwIAJhYOwbWv59rWTwDLSHbDZr7 NGbAYFSNbL3V/cRlddi6E6VWgqj/oVya94q40EyVUkWpTpCW59bluAC1/WQrk3o8 rKuDb1BORJ8RMnKM3H7vkP3RhG3Ts9+0PB0DQJPm3xz8GZXfS2FqyF76fegzUKDh sct5AfnHdbhDtrbrMuzNEJ7jvUTwlf9kWFdLeqBiPPQLQAfJ6YhueiGFjrJwOiXy loJQnTm5zUx4wyOIIUDvZZ74S7RtGqNnLL7J4uPbNKJPSe/NxT6oEBFVxOjB30oo //oAXTZbvNdeLz6Ba6w5I6/aTM/fCS/XIjCnh+3kStwpZgVlAYz61S1SORjmkWs= =ckZO -----END PGP SIGNATURE----- --Vvmlqbp57CSxeCpNSteJ3eGmoe3a5WtCU--