From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751532AbbKYWCz (ORCPT ); Wed, 25 Nov 2015 17:02:55 -0500 Received: from mail-bn1bon0133.outbound.protection.outlook.com ([157.56.111.133]:52154 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753150AbbKYWCo (ORCPT ); Wed, 25 Nov 2015 17:02:44 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Joe.Lawrence@stratus.com; Subject: Re: irq_desc use-after-free in smp_irq_move_cleanup_interrupt To: Thomas Gleixner References: <5653B688.4050809@stratus.com> CC: LKML , Jiang Liu , From: Joe Lawrence Message-ID: <56562FF7.60107@stratus.com> Date: Wed, 25 Nov 2015 17:02:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [96.252.83.116] X-ClientProxiedBy: BN3PR09CA0014.namprd09.prod.outlook.com (25.160.111.152) To SN2PR0801MB589.namprd08.prod.outlook.com (25.160.15.154) X-Microsoft-Exchange-Diagnostics: 1;SN2PR0801MB589;2:YYefx6JE2UrVDRl4YY6hiTlsGINs0BVUnutv7LSKEwThvQ7g2hsWJU/BaZlyQHjGmLVy4QZwhtxa/OiBuRGlM6WJ27Kekdw5IUrV6cpWo20amDUxL6vo+M+YiyU7MOFk3jtkRtQ1pzu17zKl9NMTuA==;3:C/esczuKzCFybynbviiOoU8vVVlvSRNT8jNu8tjQwr+0czjKTtbFvzxmosQ38lk1CqPHvfuQOuQo5kKxYU+2gumSVAuLSPms+zSCsdS6e8lFbgRh8MZvwVT/gtQfR2RF;25:ducTWDh2MBCH2VL/JdrKs3Wi5GbT6KzzZvfQ78rKU9FMGa034921FCOO4wWulwF4PueVR6IyqgmZxQ+2p3o1jUqnAbB135ogT581hy/TZ9tRhfdDhw2aVd0q1zkcuBZCHsxIpc7w+pUfw1qyzdvec5v+DiVflSxP9F9I2z/5uUVImpbfUFDC0AEFHG44m+m3fwi/qsjr9Mjucp9gN6HDA0mGNYfRLcK/daoK4cjxNTC2XLkDt4/aq4VlzZrjR/OrQ/1cnOhGQQ5jv8uXPDXrGA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0801MB589; X-Microsoft-Exchange-Diagnostics: 1;SN2PR0801MB589;20:66KhnEUgVhNWYEbnirBUSSxilImLPHvJCsnNARm74mVxBHHbrhfTXTOJ07SKV6pygbFdZqNOPCW6KVlBBYJt0WcItcHVMgXZm/uVVGmtdEefu1fseRDZsbJwqnDgCkz7OnP1fNQE+B3W1TsPqjoOXplpYPYHdozdvby68jHn9SHeOXnaF65zYXy39y1LxJcrwjicsJsa7ImCR3st/iDb71omomVWqalljKQKqMl5NlJkc3tY4k6VfVwjWg9Aix1bGf56HKo1lGEygH9igoVCqa/abOwnYX8kdlCykKXsXTgMr2nSuSwQDhEdceUQfagN3chmzfsqWDIMmueTHlLSGVNv1d+BHkdEQ2yO6MBBCO3vJmEj6B8urfyb0uniOBMyHQWKe7uG5PSrniuzYgWz+6OcBhl3IuNHUZ+Zb2wBjflkgT+pqm9eWqRFv+1D1u0WrzDXScuyaGjfSlFp+JAP2IxebNFle53b+7sjh9/0WyB09BQTbBobb9e1MQNclz+C;4:5KhXnTykhUDk7uUZ2N29JKmH2Vm5fLu4TekAYtJlYQfqQHIggKGAP3MvawaSlYShiOlTvuybEdXj+StqIDFmvUoG1o5y+IiKOqnTMRZmbLaND+45THNt7uu8GuCXifBsXexoyG7MjMUGjHjrPA8FNJ06AF4QQNmFt3GAaBtPomb/XovEoXLrIUbfiuCx/9kiupVJfUEZ/tIiAJmjFa4ukTocWOiSMMJTf8TU/1lV9D+hE1twSy+g5SY59nlByZ/uQnSeg6349spM3nPFkr6T6U9I1z0aIf7oePa88gDJntrNLW/O9rYQytbYv2Dvw+51axz9aKJlbesZUK7MRjlxeYp7OphaMtazvVFWGFmZB5MbK0roIlQJSDLTYIrLPMOS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(10201501046);SRVR:SN2PR0801MB589;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0801MB589; X-Forefront-PRVS: 0771670921 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(979002)(6009001)(6069001)(199003)(52604005)(377454003)(479174004)(189002)(24454002)(50466002)(101416001)(586003)(5008740100001)(189998001)(81156007)(87976001)(3846002)(92566002)(6116002)(65806001)(40100003)(2950100001)(65956001)(83506001)(1096002)(66066001)(77096005)(36756003)(47776003)(93886004)(33656002)(54356999)(64126003)(230783001)(105586002)(97736004)(42186005)(230700001)(50986999)(76176999)(86362001)(23746002)(122386002)(5004730100002)(106356001)(65816999)(110136002)(4001350100001)(5001960100002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:SN2PR0801MB589;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN2PR0801MB589;23:YbaPxUwoM9S4LMulxfCZVdYte5We4tz7Lfx7?= =?Windows-1252?Q?INnegIgC/Ja46kzFMEGjBtp/GHnPk82ggSXYpvCXEPUQsyLpQvEobg3m?= =?Windows-1252?Q?jBTo7UWLuN2vP7Yb84edK7po4u8X35dqlg8YbZaRRqHvgGnwBZG2dljc?= =?Windows-1252?Q?14tjAy7GiL9dlE3YVnblagRzlTrHv2wOwADKHr79XEsmkDIBxiR6ofTX?= =?Windows-1252?Q?NNXCWMrZgEJcnaSiuGmJhkdid0+uiKYvMkErxvE+5UbGFpuN1jND21JV?= =?Windows-1252?Q?Z3ZzRy0knSdPo5VrpcIrskl2p5boAnyvWjfuteWQ69ZHUR6BH1xZfLR6?= =?Windows-1252?Q?qqDDGtlbWG7u/f6T6tV8JrWTs4p455VuJQ18X5Tb4kStwSj6eBNPuKFt?= =?Windows-1252?Q?QlZTBXqaKvbkmol3SCYFSVKwjXjH6ffPMmkB87aQ7xVlOLi1WsHsWyNd?= =?Windows-1252?Q?+JE0jC88lrY+mLmVS0bvav7kFxEX9RppESVmvvOdHOQ6/ZlX7Y1MXOQ1?= =?Windows-1252?Q?imDTCfGL6770uPdqpje0dS7bBDyHsCZ0nST8IAFLwo+PaBk8N4VC+J7P?= =?Windows-1252?Q?btyQ3zoktL+GckwWJ/rDU7XK1GWa1MxzIwSh2hcG1TWHnjNNu8aWjjHh?= =?Windows-1252?Q?hQNp5jBpzVxpqGc3+hII2lY+xvftSly1Ma6qgPCxHGBQ7LqCw6bU1zyv?= =?Windows-1252?Q?WgrtOThRBOycrN5qdMuwIVbtcosgGG4ffUfC/UXEjTRMt84yYJTxz8++?= =?Windows-1252?Q?9M9sNHCaW5Qk1aRvS/gyhjdw5wSH8CABcG+9u/SjgME+WaG4xv5zaeeZ?= =?Windows-1252?Q?g/Ihllb0og7F8IQmFEfMkAobOLLM3//5s31Qq3Zhus6FpzIgKms1Sn7D?= =?Windows-1252?Q?1U4Fy62I6KiaG481u5xrmeSHihC/eJWhxZPOXsKcSmDmKUuxRiOeyGAs?= =?Windows-1252?Q?cLUEdNi5k023/9xvBa9WfWID+J4Z3/mPnejaYUo/gdBN1tkKDtEOsgpP?= =?Windows-1252?Q?+Gs13iD4TTucDBltksOmatnmaHJthFSLC+Kn0i5znozxCsOWf4CeowKc?= =?Windows-1252?Q?616Pr1iLhxCOFO7XI7it1J+U8pZE8dXT9j/OaKfC+CY/n9ChxuFzezP0?= =?Windows-1252?Q?oXdtuin4Vcm8AFz0hBGHO/XFroya0NwmjMHzKCbIYoCeKIMhLdkc0W8X?= =?Windows-1252?Q?EAlzURDjXwsloZdd2VE42QajWw4ZXYxczf+MlED0djn1H2zDLCP0z/SI?= =?Windows-1252?Q?PDiSM6dCoVNgO/0n1/XozcEouVMPbVAjzmVuTRuz2RGNfV52nV5VJc8M?= =?Windows-1252?Q?MYhGPqbm0C0SezQoXZxbDq/UQn2+6KbBBrNpfwCoLE97wrPfWmVeOZ64?= =?Windows-1252?Q?uQOmedxPZ8d3qlsubtXKQvALhH2oC1DymJcQXwf/UiahiIZJCYDyB8iR?= =?Windows-1252?Q?sGjpIWk8Vz1f3Mk38avP?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR0801MB589;5:12ElxUL92Vow3DfkdMlvtdmcV9ApOkVVXz4hzKzSr6T1nNSs8o6upiaRZmOTIWdHYhsaWOsdiFnWKlNKvkc9apmm0+l/fWtMM4m9JFoE8iOkd37x5dux5VZ4AJAcFvTWdogATcrNsImSS+v/0M90Zw==;24:xF2/SR6yITbbQO/yKxgDhft1Te5zfKmK73DfWn3/mVn5LySzNcNYSjYmB+bn2ixd4RNYzyXP2GtEgZmaQaImXEsFWVL75+2nB2uHOm9z5Dk=;20:x5ISp8xO+8ss9arI8QueiCbjTSNRDJBlpJBe5136ftUPtP6haTApFnvRr8YxmESmAobyifiemLcQAbI9pHAE4SolrF9GOmuVw9lpdeRK/shUWAA6UHLVQ0Rtr+kcHZ6hP+fCpx3/fLlKc+H6TrGC+E6XpUWrm3Q987CQZGXfNnk= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2015 22:02:39.6332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0801MB589 X-Microsoft-Exchange-Diagnostics: 1;SN2PR0801MB576;2:9T2AaHONLgOHxa8Q5hWzHWL8Hd1zUgnovctlXnOuNH9oCI+xSAI2HnEYFXoaLzD67uadvOEIUBCP/J510uLrK3qxv8HXSZKygLBwr9jOB5FlBGI7n/X1u8QsjwOK8wPGvHBBzA2UL8B7hzmvEu96qQ==;23:VqXxD0BA6K01FcDPK5XS+GZYoGOtKlT8Vj2lAtqnmUrBq8UnhRtycs1Mr7eKBGeVkvtN51VMnu2ttdQ8F5VwuqTYhZXH6MFj4LqSKs2i0JC9Ce4RQryZO9oAMQvLgfALU9FGoVDKSsu5VkSlGADwPj1DgiZKJlHsFZajYrb4WA9Xd2y5pNX+Ilid9Mt5tAel X-OriginatorOrg: stratus.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2015 04:12 PM, Thomas Gleixner wrote: > On Wed, 25 Nov 2015, Thomas Gleixner wrote: >> So if CPU1 gets the IPI _BEFORE_ move_in_progress is set to 0, and >> does not get another IPI before the next move ..... That has been that >> way forever. >> >> Duh. Working on a real fix this time. > > Here you go. Completely untested of course. > Hi Thomas -- thanks for taking a look! (Well, the analysis looks like more than *just* a look :) I'll give the patch a go when I get back in the office next week. -- Joe