From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH] build: fix dependencies for files compiled
 from their parent directory
Date: Thu, 26 Nov 2015 00:43:26 -0700
Message-ID: <5656C62E02000078000B93C6@prv-mh.provo.novell.com>
References: <5655ECEA02000078000B91E0@prv-mh.provo.novell.com>
	<1448468791.17688.136.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1a1rDH-00034S-VV
	for xen-devel@lists.xenproject.org; Thu, 26 Nov 2015 07:43:32 +0000
In-Reply-To: <1448468791.17688.136.camel@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Jonathan Creekmore <jonathan.creekmore@gmail.com>, Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 25.11.15 at 17:26, <ian.campbell@citrix.com> wrote:
> On Wed, 2015-11-25 at 09:16 -0700, Jan Beulich wrote:
>> The use of $(basename ...) here was wrong (yet I'm sure I tested it).
> 
> Is the issue here that xen/arch/x86/x86_64/.compat.o.d ought really to be
> xen/arch/x86/.x86_64.compat.o.d?

No, xen/arch/x86/x86_64/.compat.o.d is the correct name. Just
that $(dir $(1)).$(basename $(notdir $(1))).d produces
xen/arch/x86/x86_64/.compat.d (i.e. strips the .o, which is not in
line with $(@D)/.$(@F).d used to generate those files), and hence
neither dependency tracking nor cleaning work.

Jan